Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 10084020: Removing defunct code around PureViews. (Closed)

Created:
8 years, 8 months ago by Emmanuel Saint-loubert-Bié
Modified:
8 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, James Su, ben+watch_chromium.org, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Removing defunct code around PureViews. BUG=117493 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132357

Patch Set 1 #

Patch Set 2 : Fixed misplaced endif #

Patch Set 3 : Merge tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -109 lines) Patch
M chrome/browser/ui/omnibox/omnibox_view_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 8 chunks +39 lines, -46 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_win.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M ui/views/controls/combobox/native_combobox_views_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/controls/combobox/native_combobox_win.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/views/controls/scrollbar/scrollbar_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_win.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 chunk +6 lines, -8 lines 0 comments Download
M ui/views/view_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/views.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/native_widget_win.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M ui/views/widget/widget.h View 1 chunk +0 lines, -5 lines 0 comments Download
M ui/views/widget/widget.cc View 2 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Emmanuel Saint-loubert-Bié
Hi Scott, Some cleanup. I will run all the trybots for all the configs impacted ...
8 years, 8 months ago (2012-04-13 20:25:15 UTC) #1
tfarina
On 2012/04/13 20:25:15, Emmanuel Saint-loubert wrote: > Hi Scott, > > Some cleanup. I will ...
8 years, 8 months ago (2012-04-13 20:27:26 UTC) #2
sky
LGTM
8 years, 8 months ago (2012-04-13 21:43:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/saintlou@chromium.org/10084020/9004
8 years, 8 months ago (2012-04-15 02:57:22 UTC) #4
commit-bot: I haz the power
8 years, 8 months ago (2012-04-15 04:45:11 UTC) #5
Change committed as 132357

Powered by Google App Engine
This is Rietveld 408576698