Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(894)

Unified Diff: chrome/test/pyautolib/chromeos/suid_actions.py

Issue 10084005: Mitigate race caused by flimflam restart in CleanFlimflamDirs() (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/functional/chromeos_onc.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/pyautolib/chromeos/suid_actions.py
diff --git a/chrome/test/pyautolib/chromeos/suid_actions.py b/chrome/test/pyautolib/chromeos/suid_actions.py
index fe8d311bfb1319500e14283489f91eb54a031490..a4a9ce06c5a8e317ca2353ed2944c1650703caea 100755
--- a/chrome/test/pyautolib/chromeos/suid_actions.py
+++ b/chrome/test/pyautolib/chromeos/suid_actions.py
@@ -44,7 +44,12 @@ class SuidAction(object):
## Actions ##
def CleanFlimflamDirs(self):
- """Clean the contents of all flimflam profiles."""
+ """Clean the contents of all flimflam profiles.
+
+ TODO(stanleyw): crosbug.com/29421 This method restarts flimflam. It should
+ wait until flimflam is fully initialized and accessible via DBus. Otherwise,
+ there is a race conditions and subsequent accesses to flimflam may fail.
+ """
flimflam_dirs = ['/home/chronos/user/flimflam',
'/var/cache/flimflam']
os.system('stop flimflam')
« no previous file with comments | « chrome/test/functional/chromeos_onc.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698