Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 10084005: Mitigate race caused by flimflam restart in CleanFlimflamDirs() (Closed)

Created:
8 years, 8 months ago by bartfab (slow)
Modified:
8 years, 8 months ago
Reviewers:
stanleyw, Nirnimesh
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Mitigate race caused by flimflam restart in CleanFlimflamDirs() CleanFlimflamDirs() restarts flimflam but does not wait for it to be fully initialized before returning. This CL mitigates the issue by restarting Chrome next, giving flimflam ample time to initialize before the test actually continues. A proper fix will be developed in crosbug.com/29421. BUG=chromium-os:29400 TEST=PyAuto chromeos_onc.py Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132333

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M chrome/test/functional/chromeos_onc.py View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/test/pyautolib/chromeos/suid_actions.py View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
bartfab (slow)
This is a stop-gap for a race that unbreaks ONC tests. Could you have a ...
8 years, 8 months ago (2012-04-13 13:04:55 UTC) #1
Nirnimesh
LGTM
8 years, 8 months ago (2012-04-13 17:38:21 UTC) #2
stanleyw
lgtm
8 years, 8 months ago (2012-04-13 17:41:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/10084005/1
8 years, 8 months ago (2012-04-13 21:31:05 UTC) #4
commit-bot: I haz the power
Try job failure for 10084005-1 (retry) on linux_rel for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-13 22:12:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bartfab@chromium.org/10084005/1
8 years, 8 months ago (2012-04-14 09:06:35 UTC) #6
commit-bot: I haz the power
8 years, 8 months ago (2012-04-14 10:56:32 UTC) #7
Change committed as 132333

Powered by Google App Engine
This is Rietveld 408576698