gdata: Support opening zip file on Google Docs.

chromeos/dbus/cros_disks_client.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMEOS_DBUS_CROS_DISKS_CLIENT_H_
 #define CHROMEOS_DBUS_CROS_DISKS_CLIENT_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 160 matching lines @@
   // A callback to handle mount events.
   // The first argument is the event type.
   // The second argument is the device path.
   typedef base::Callback<void(MountEventType, const std::string&)
                          > MountEventHandler;
 
   virtual ~CrosDisksClient();
 
   // Calls Mount method.  |callback| is called after the method call succeeds,
   // otherwise, |error_callback| is called.
+  // The argument |source_format| can be empty, in which case the source format
+  // is auto-detected.

[satorux1, 2012/04/24 22:54:15]

please also document valid values for this. maybe ".zip" is valid?

[hshi, 2012/04/24 23:00:04]

The list of valid values is not small. According to
chrome/browser/resources/file_manager/manifest.json, there are currently 8
extensions (.rar, .tar, .tar.bz2, .tar.gz, .tgz, .tgz2, .tgz, .zip) registered
under the file browser handler "mount-archive". I don't know if these 8 types
are really all supported by CrOS or not (it may vary on different platforms
also)

On 2012/04/24 22:54:15, satorux1 wrote:

[satorux1, 2012/04/24 23:01:29]

Then, I'd use ".zip" as an example, and add a reference to the file.

[Ben Chan, 2012/04/24 23:04:16]

They are all supported by CrOS regardless of platform.

But I think the emphasis here should be that, when mounting an archive, we pass
the file extension (with the leading dot) as |source_format|.

[hshi, 2012/04/24 23:10:14]

Done with emphasis on the fact that extension should contain the leading dot.

   virtual void Mount(const std::string& source_path,
+                     const std::string& source_format,
                      MountType type,
                      const MountCallback& callback,
                      const ErrorCallback& error_callback) = 0;
 
   // Calls Unmount method.  |callback| is called after the method call succeeds,
   // otherwise, |error_callback| is called.
   virtual void Unmount(const std::string& device_path,
                        const UnmountCallback& callback,
                        const ErrorCallback& error_callback) = 0;
 
@@ skipping 32 matching lines @@
   // Create() should be used instead.
   CrosDisksClient();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(CrosDisksClient);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROMEOS_DBUS_CROS_DISKS_CLIENT_H_