Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Unified Diff: webkit/plugins/ppapi/ppapi_webplugin_impl.h

Issue 10083059: [Print Preview] Modified PP_PrintSettings_Dev interface to support auto fit to page functionality. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed review comments Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/plugins/ppapi/ppapi_webplugin_impl.h
diff --git a/webkit/plugins/ppapi/ppapi_webplugin_impl.h b/webkit/plugins/ppapi/ppapi_webplugin_impl.h
index ae319a8d65f1973ba90047b1325b88f1e6944ac8..3a58907748afbd0af5adffbe4907c76ee9a6cc5b 100644
--- a/webkit/plugins/ppapi/ppapi_webplugin_impl.h
+++ b/webkit/plugins/ppapi/ppapi_webplugin_impl.h
@@ -13,11 +13,13 @@
#include "base/message_loop_helpers.h"
#include "ppapi/c/pp_var.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebPlugin.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebPrintScalingOption.h"
#include "ui/gfx/rect.h"
#include "webkit/plugins/webkit_plugins_export.h"
namespace WebKit {
struct WebPluginParams;
+struct WebSize;
}
namespace webkit {
@@ -77,8 +79,16 @@ class WebPluginImpl : public WebKit::WebPlugin {
virtual void stopFind();
virtual bool supportsPaginatedPrint() OVERRIDE;
virtual bool isPrintScalingDisabled() OVERRIDE;
- virtual int printBegin(const WebKit::WebRect& printable_area,
- int printer_dpi) OVERRIDE;
+
+ // TODO(kmadhusu): Remove this function after fixing crbug.com/85132 and add
+ // OVERRIDE keyword to the overloaded function.
+ virtual int printBegin(const WebKit::WebRect& content_area,
+ int printer_dpi);
+ virtual int printBegin(const WebKit::WebRect& content_area,
+ const WebKit::WebRect& printable_area,
+ const WebKit::WebSize& paper_size,
+ WebKit::WebPrintScalingOption scaling_option,
+ int printer_dpi);
virtual bool printPage(int page_number, WebKit::WebCanvas* canvas) OVERRIDE;
virtual void printEnd() OVERRIDE;

Powered by Google App Engine
This is Rietveld 408576698