[Print Preview] Modified PP_PrintSettings_Dev interface to support auto fit to page functionality.

webkit/plugins/ppapi/ppapi_plugin_instance.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_PLUGINS_PPAPI_PPAPI_PLUGIN_INSTANCE_H_
 #define WEBKIT_PLUGINS_PPAPI_PPAPI_PLUGIN_INSTANCE_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 215 matching lines @@
   void RequestSurroundingText(size_t desired_number_of_characters);
   void Zoom(double factor, bool text_only);
   bool StartFind(const string16& search_text,
                  bool case_sensitive,
                  int identifier);
   void SelectFindResult(bool forward);
   void StopFind();
 
   bool SupportsPrintInterface();
   bool IsPrintScalingDisabled();
-  int PrintBegin(const gfx::Rect& printable_area, int printer_dpi);
+
+  // TODO(kmadhusu): Change the data type of |print_scaling_option| to
+  // WebKit::WebPrintScalingOption after fixing crbug.com/85132.

[dmichael (off chromium), 2012/04/20 23:01:45]

Are you sure that's going to work okay? int and WebPrintScalingOption are
distinct types. Even though an enum can implicitly convert to an int, I doubt it
will work right for overriding a virtual function.

You might need to land a WebKit side change first to add the new virtual
function with a default implementation... but somebody with more WebKit
experience (vandebo?) will be able to advise you about the right way to go.

[vandebo (ex-Chrome), 2012/04/21 01:06:49]

Kausalya and I talked about it, and yes, the enum needs to go into WebKit first.
It took us a bit to understand what you meant here (darn overloaded english
words).  What you suggest would maintain compile-ability of the codebase, but
would break printing when in the middle of the multi-repo commit.  This way
printing continues to work throughout the process.

[kmadhusu, 2012/04/23 16:39:30]

As you said int and WebPrintScalingOption are distinct types. If you see my
webkit patch, you will notice that I had "int" data type for
print_scaling_option param.
 

[dmichael (off chromium), 2012/04/23 17:02:40]

Okay, that would have worked for the initial commit, but would have broken had
you changed to the enum in the interface later. In any case, I like using the
enum in the API and landing a WebKit change with the enum first better, as you
seem to be proposing to do now.

+  int PrintBegin(const gfx::Rect& content_area,
+                 const gfx::Rect& printable_area,
+                 const gfx::Size& paper_size,
+                 int print_scaling_option,
+                 int printer_dpi);
   bool PrintPage(int page_number, WebKit::WebCanvas* canvas);
   void PrintEnd();
 
   bool CanRotateView();
   void RotateView(WebKit::WebPlugin::RotationType type);
 
   void Graphics3DContextLost();
 
   // There are 2 implementations of the fullscreen interface
   // PPB_FlashFullscreen is used by Pepper Flash.
@@ skipping 390 matching lines @@
   // a user gesture after it has been processed.
   PP_TimeTicks pending_user_gesture_;
 
   DISALLOW_COPY_AND_ASSIGN(PluginInstance);
 };
 
 }  // namespace ppapi
 }  // namespace webkit
 
 #endif  // WEBKIT_PLUGINS_PPAPI_PPAPI_PLUGIN_INSTANCE_H_