content/common/gpu/client/command_buffer_proxy_impl.cc - Issue 10083056: GpuMemoryManager suggests values for renderer Contents Texture Managers' preferred memory limit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/command_buffer_proxy_impl.cc

Issue 10083056: GpuMemoryManager suggests values for renderer Contents Texture Managers' preferred memory limit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: On max 10.5, it fails to init command buffer, and my callback code didn't guard against that. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/gpu/client/command_buffer_proxy_impl.cc

diff --git a/content/common/gpu/client/command_buffer_proxy_impl.cc b/content/common/gpu/client/command_buffer_proxy_impl.cc

index ce54be7538fad85c94591273d83bdad75dd1f931..58ca3af7e3c6a41592f1ef909410122d1d665135 100644

--- a/content/common/gpu/client/command_buffer_proxy_impl.cc

+++ b/content/common/gpu/client/command_buffer_proxy_impl.cc

@@ -105,6 +105,8 @@ void CommandBufferProxyImpl::SetMemoryAllocationChangedCallback(

const base::Callback<void(const GpuMemoryAllocationForRenderer&)>&

callback) {

memory_allocation_changed_callback_ = callback;

+ Send(new GpuCommandBufferMsg_SetClientHasMemoryAllocationChangedCallback(

+ route_id_, !memory_allocation_changed_callback_.is_null()));

}

void CommandBufferProxyImpl::OnSetMemoryAllocation(

« no previous file with comments | « no previous file | content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc » ('j') | no next file with comments »