content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc - Issue 10083056: GpuMemoryManager suggests values for renderer Contents Texture Managers' preferred memory limit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

Issue 10083056: GpuMemoryManager suggests values for renderer Contents Texture Managers' preferred memory limit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing issue with every proxy registering a callback, even when it is null. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/client/command_buffer_proxy_impl.cc ('k') | content/common/gpu/gpu_command_buffer_stub.h » ('j') | content/common/gpu/gpu_command_buffer_stub.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

diff --git a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

index 6fcce8a4014f5d56b32aeff0aa7a06136ec7d11c..7533d044cd3226162d9a368bf60eeb1a2ac922b6 100644

--- a/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

+++ b/content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc

@@ -264,10 +264,6 @@ bool WebGraphicsContext3DCommandBufferImpl::MaybeInitializeGL(

g_all_shared_contexts.Pointer()->insert(this);

}

- command_buffer_->SetMemoryAllocationChangedCallback(base::Bind(

- &WebGraphicsContext3DCommandBufferImpl::OnMemoryAllocationChanged,

- weak_ptr_factory_.GetWeakPtr()));

visible_ = true;

initialized_ = true;

return true;

@@ -680,6 +676,10 @@ void WebGraphicsContext3DCommandBufferImpl::

setMemoryAllocationChangedCallbackCHROMIUM(

WebGraphicsMemoryAllocationChangedCallbackCHROMIUM* callback) {

memory_allocation_changed_callback_ = callback;

nduca 2012/04/23 22:12:18 what if they clear clear it? You need to remove th

+ command_buffer_->SetMemoryAllocationChangedCallback(base::Bind(

+ &WebGraphicsContext3DCommandBufferImpl::OnMemoryAllocationChanged,

+ weak_ptr_factory_.GetWeakPtr()));

}