IndexedDB: Support get/getKey(keyRange)

IndexedDB: Support get/getKey(keyRange)	

This is the Chromium IPC plumbing to talk to the WebKit API.
This won't be used until https://bugs.webkit.org/show_bug.cgi?id=83638
is fixed.

BUG=92047
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132918

[alecflett, 2012-04-18 18:56:56]

Please take a look... it's basically all boilerplate

[jsbell, 2012-04-18 19:23:44]

lgtm with naming/formatting nits

https://chromiumcodereview.appspot.com/10083053/diff/1/content/browser/in_pro...
File content/browser/in_process_webkit/indexed_db_dispatcher_host.h (right):

https://chromiumcodereview.appspot.com/10083053/diff/1/content/browser/in_pro...
content/browser/in_process_webkit/indexed_db_dispatcher_host.h:175: void
OnGetObjectByRange(int idb_index_id,
FYI, if anyone gives you grief about poorly named members, point them at:
crbug.com/107373

https://chromiumcodereview.appspot.com/10083053/diff/1/content/common/indexed...
File content/common/indexed_db/indexed_db_dispatcher.cc (right):

https://chromiumcodereview.appspot.com/10083053/diff/1/content/common/indexed...
content/common/indexed_db/indexed_db_dispatcher.cc:382: idb_index_id,
CurrentWorkerId(),
Should have 4 more spaces of indent

https://chromiumcodereview.appspot.com/10083053/diff/1/content/common/indexed...
File content/common/indexed_db/proxy_webidbindex_impl.h (right):

https://chromiumcodereview.appspot.com/10083053/diff/1/content/common/indexed...
content/common/indexed_db/proxy_webidbindex_impl.h:43: virtual void
getObject(const WebKit::WebIDBKeyRange& key,
Consistency: this parameter is named key_range in the implementation.

https://chromiumcodereview.appspot.com/10083053/diff/1/content/common/indexed...
content/common/indexed_db/proxy_webidbindex_impl.h:51: virtual void getKey(const
WebKit::WebIDBKeyRange& key,
Consistency: this parameter is named key_range in the implementation.

https://chromiumcodereview.appspot.com/10083053/diff/1/content/common/indexed...
File content/common/indexed_db/proxy_webidbobjectstore_impl.h (right):

https://chromiumcodereview.appspot.com/10083053/diff/1/content/common/indexed...
content/common/indexed_db/proxy_webidbobjectstore_impl.h:35: virtual void
get(const WebKit::WebIDBKeyRange&,
Parameters aren't named; I'm not finding guidance in the Chromium or Google
style guide. Other method declarations have them, so include them?

[alecflett, 2012-04-18 20:16:07]

https://chromiumcodereview.appspot.com/10083053/diff/1/content/common/indexed...
File content/common/indexed_db/indexed_db_dispatcher.cc (right):

https://chromiumcodereview.appspot.com/10083053/diff/1/content/common/indexed...
content/common/indexed_db/indexed_db_dispatcher.cc:382: idb_index_id,
CurrentWorkerId(),
On 2012/04/18 19:23:44, jsbell wrote:
> Should have 4 more spaces of indent

Done.

https://chromiumcodereview.appspot.com/10083053/diff/1/content/common/indexed...
File content/common/indexed_db/proxy_webidbindex_impl.h (right):

https://chromiumcodereview.appspot.com/10083053/diff/1/content/common/indexed...
content/common/indexed_db/proxy_webidbindex_impl.h:43: virtual void
getObject(const WebKit::WebIDBKeyRange& key,
On 2012/04/18 19:23:44, jsbell wrote:
> Consistency: this parameter is named key_range in the implementation.

Done.

https://chromiumcodereview.appspot.com/10083053/diff/1/content/common/indexed...
content/common/indexed_db/proxy_webidbindex_impl.h:51: virtual void getKey(const
WebKit::WebIDBKeyRange& key,
On 2012/04/18 19:23:44, jsbell wrote:
> Consistency: this parameter is named key_range in the implementation.

Done.

https://chromiumcodereview.appspot.com/10083053/diff/1/content/common/indexed...
File content/common/indexed_db/proxy_webidbobjectstore_impl.h (right):

https://chromiumcodereview.appspot.com/10083053/diff/1/content/common/indexed...
content/common/indexed_db/proxy_webidbobjectstore_impl.h:35: virtual void
get(const WebKit::WebIDBKeyRange&,
On 2012/04/18 19:23:44, jsbell wrote:
> Parameters aren't named; I'm not finding guidance in the Chromium or Google
> style guide. Other method declarations have them, so include them?

Fixed to at least be consistent with the file

[commit-bot: I haz the power, 2012-04-18 20:16:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/alecflett@chromium.org/10083053/5002

[commit-bot: I haz the power, 2012-04-19 02:35:34]

Change committed as 132918