Issue 10083045: UMA for new account creation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10083045: UMA for new account creation (Closed)

Created:
8 years, 8 months ago by Denis Kuznetsov (DE-MUC)

Modified:
8 years, 8 months ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

UMA for new account creation BUG=chromium-os:29612 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133488

Patch Set 2 : Change UMA declaration #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/chromeos/login/existing_user_controller.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

https://chromiumcodereview.appspot.com/10083045/diff/1/chrome/browser/chromeos/login/existing_user_controller.cc File chrome/browser/chromeos/login/existing_user_controller.cc (right): https://chromiumcodereview.appspot.com/10083045/diff/1/chrome/browser/chromeos/login/existing_user_controller.cc#newcode270 chrome/browser/chromeos/login/existing_user_controller.cc:270: UMA_HISTOGRAM_COUNTS("Login.CreateAccount", 1); UMA_HISTOGRAM_ENUMERATION seems to be a better fit ...

8 years, 8 months ago (2012-04-18 17:45:08 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/10083045/4001

8 years, 8 months ago (2012-04-23 16:46:11 UTC) #5

Change committed as 133488

Expand Messages | Collapse Messages

Issue 10083045: UMA for new account creation (Closed)

Description

Patch Set 1 #

Patch Set 2 : Change UMA declaration #

Messages