Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 10082026: mac: Minor bug fix: 2.5 cannot be stored in an int. (Closed)

Created:
8 years, 8 months ago by Nico
Modified:
8 years, 8 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, asanka, Randy Smith (Not in Mondays)
Visibility:
Public.

Description

mac: Minor bug fix: 2.5 cannot be stored in an int. Found by clang's newly enabled -Wliteral-conversion: ../../chrome/browser/ui/cocoa/download/download_item_cell.mm:75:40: error: implicit conversion turns literal floating-point number into integer: 'double' to 'const int' [-Werror,-Wliteral-conversion] const int kCompleteAnimationDuration = 2.5; ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~ ../../chrome/browser/ui/cocoa/download/download_item_cell.mm:78:43: error: implicit conversion turns literal floating-point number into integer: 'double' to 'const int' [-Werror,-Wliteral-conversion] const int kInterruptedAnimationDuration = 2.5; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~ 2 errors generated. BUG=none TEST=download animation runs 0.5s longer. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132324

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/download/download_item_cell.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Avi (use Gerrit)
lgtm
8 years, 8 months ago (2012-04-13 22:30:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10082026/1
8 years, 8 months ago (2012-04-13 22:33:25 UTC) #2
commit-bot: I haz the power
Try job failure for 10082026-1 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-04-14 00:54:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10082026/1
8 years, 8 months ago (2012-04-14 00:56:19 UTC) #4
commit-bot: I haz the power
8 years, 8 months ago (2012-04-14 04:15:44 UTC) #5
Change committed as 132324

Powered by Google App Engine
This is Rietveld 408576698