Issue 10082021: TabContents -> WebContentsImpl, part 13.

Issue 10082021: TabContents -> WebContentsImpl, part 13. (Closed)

Created:
8 years, 8 months ago by Avi (use Gerrit)

Modified:
8 years, 8 months ago

Reviewers:
jam

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, creis+watch_chromium.org, ajwong+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

TabContents -> WebContentsImpl, part 13. Remove the TabContents typedef. BUG=105875 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132410

Patch Set 2 : rebase, fix references #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -40 lines)			Patch
M	content/browser/browser_plugin/browser_plugin_web_contents_observer.cc	View		8 chunks	+21 lines, -22 lines	0 comments	Download
M	content/browser/renderer_host/render_view_host_manager_browsertest.cc	View	1	2 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/site_instance_impl_unittest.cc	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	content/browser/ssl/ssl_policy.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.h	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	content/test/test_renderer_host.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

https://chromiumcodereview.appspot.com/10082021/diff/1/content/browser/web_contents/web_contents_impl.cc File content/browser/web_contents/web_contents_impl.cc (right): https://chromiumcodereview.appspot.com/10082021/diff/1/content/browser/web_contents/web_contents_impl.cc#newcode1775 content/browser/web_contents/web_contents_impl.cc:1775: void WebContentsImpl::OnPepperPluginHung(int plugin_child_id, hahahahaha

8 years, 8 months ago (2012-04-13 21:19:58 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10082021/1

8 years, 8 months ago (2012-04-16 14:01:28 UTC) #3

commit-bot: I haz the power

Try job failure for 10082021-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...

8 years, 8 months ago (2012-04-16 14:29:25 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10082021/8004

8 years, 8 months ago (2012-04-16 14:36:16 UTC) #5

Change committed as 132410

Expand Messages | Collapse Messages