Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10082020: Metro/HiDPI: Use metro resource pak in metro mode (Closed)

Created:
8 years, 8 months ago by sail
Modified:
8 years, 8 months ago
CC:
chromium-reviews, grt+watch_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Metro/HiDPI: Use metro resource pak in metro mode This CL does the following: - add a new enable_metro build flag - if the build flag is set then add a new metro icon resource pak to chrome - at run time if Chrome is running in metro mode AND ENABLE_METRO is set then use the metro icon resource pak BUG=114311 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133843

Patch Set 1 #

Patch Set 2 : a #

Total comments: 4

Patch Set 3 : address review comments #

Patch Set 4 : a #

Patch Set 5 : a #

Patch Set 6 : a #

Total comments: 5

Patch Set 7 : address review comments #

Patch Set 8 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -10 lines) Patch
M build/common.gypi View 1 2 3 4 5 6 5 chunks +9 lines, -0 lines 0 comments Download
M chrome/app/theme/theme_resources_metro_1x.grd View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_resources.gyp View 1 2 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/installer/mini_installer/chrome.release View 1 2 3 4 5 6 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/tools/build/win/create_installer_archive.py View 1 2 3 4 5 6 4 chunks +8 lines, -3 lines 0 comments Download
M chrome/tools/build/win/release.rules View 1 chunk +1 line, -1 line 0 comments Download
M tools/gritsettings/resource_ids View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M ui/base/resource/resource_bundle_win.cc View 1 2 3 4 5 6 2 chunks +16 lines, -4 lines 0 comments Download
A ui/base/win/metro.h View 1 2 3 4 5 1 chunk +18 lines, -0 lines 0 comments Download
A ui/base/win/metro.cc View 1 2 3 4 5 6 7 1 chunk +20 lines, -0 lines 0 comments Download
M ui/ui.gyp View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
sail
8 years, 8 months ago (2012-04-13 22:43:47 UTC) #1
sky
http://codereview.chromium.org/10082020/diff/2001/chrome/chrome_resources.gyp File chrome/chrome_resources.gyp (right): http://codereview.chromium.org/10082020/diff/2001/chrome/chrome_resources.gyp#newcode254 chrome/chrome_resources.gyp:254: ['OS != "mac" and enable_metro == 1', { Isn't ...
8 years, 8 months ago (2012-04-13 22:56:14 UTC) #2
sail
http://codereview.chromium.org/10082020/diff/2001/chrome/chrome_resources.gyp File chrome/chrome_resources.gyp (right): http://codereview.chromium.org/10082020/diff/2001/chrome/chrome_resources.gyp#newcode254 chrome/chrome_resources.gyp:254: ['OS != "mac" and enable_metro == 1', { On ...
8 years, 8 months ago (2012-04-18 15:46:39 UTC) #3
sky
LGTM
8 years, 8 months ago (2012-04-18 16:04:00 UTC) #4
cpu_(ooo_6.6-7.5)
http://codereview.chromium.org/10082020/diff/11002/ui/base/win/metro.cc File ui/base/win/metro.cc (right): http://codereview.chromium.org/10082020/diff/11002/ui/base/win/metro.cc#newcode10 ui/base/win/metro.cc:10: that is the deprecated way :) Use http://src.chromium.org/viewvc/chrome/trunk/src/base/win/metro.h?revision=131440&view=markup basically ...
8 years, 8 months ago (2012-04-19 19:52:14 UTC) #5
robertshield
lg, couple of nits. http://codereview.chromium.org/10082020/diff/11002/chrome/tools/build/win/create_installer_archive.py File chrome/tools/build/win/create_installer_archive.py (right): http://codereview.chromium.org/10082020/diff/11002/chrome/tools/build/win/create_installer_archive.py#newcode393 chrome/tools/build/win/create_installer_archive.py:393: help='Whether to include Metro resource ...
8 years, 8 months ago (2012-04-19 20:16:35 UTC) #6
sail
http://codereview.chromium.org/10082020/diff/11002/chrome/tools/build/win/create_installer_archive.py File chrome/tools/build/win/create_installer_archive.py (right): http://codereview.chromium.org/10082020/diff/11002/chrome/tools/build/win/create_installer_archive.py#newcode393 chrome/tools/build/win/create_installer_archive.py:393: help='Whether to include Metro resource files.') On 2012/04/19 20:16:35, ...
8 years, 8 months ago (2012-04-24 04:53:36 UTC) #7
sail
waiting for Robert's LGTM before landing.
8 years, 8 months ago (2012-04-24 04:53:55 UTC) #8
robertshield
On 2012/04/24 04:53:36, sail wrote: > http://codereview.chromium.org/10082020/diff/11002/chrome/tools/build/win/create_installer_archive.py > File chrome/tools/build/win/create_installer_archive.py (right): > > http://codereview.chromium.org/10082020/diff/11002/chrome/tools/build/win/create_installer_archive.py#newcode393 > ...
8 years, 8 months ago (2012-04-24 21:07:55 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/10082020/17001
8 years, 8 months ago (2012-04-24 23:06:20 UTC) #10
commit-bot: I haz the power
Try job failure for 10082020-17001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-24 23:28:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sail@chromium.org/10082020/28002
8 years, 8 months ago (2012-04-25 00:03:29 UTC) #12
commit-bot: I haz the power
8 years, 8 months ago (2012-04-25 02:24:25 UTC) #13 
Change committed as 133843

Powered by Google App Engine
This is Rietveld 408576698