Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 10081026: Chromoting Host installation should take into account both buildtype% and branding%. (Closed)

Created:
8 years, 8 months ago by alexeypa (please no reviews)
Modified:
8 years, 8 months ago
Reviewers:
Jamie
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Chromoting Host installation should take into account both buildtype% and branding%. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132317

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M remoting/host/installer/chromoting.wxs View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting.gyp View 3 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
alexeypa (please no reviews)
PTAL
8 years, 8 months ago (2012-04-13 23:04:38 UTC) #1
Jamie
lgtm
8 years, 8 months ago (2012-04-13 23:29:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/10081026/1
8 years, 8 months ago (2012-04-13 23:54:59 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-14 03:02:42 UTC) #4
Change committed as 132317

Powered by Google App Engine
This is Rietveld 408576698