Call XmppSignalStrategy::SetAuthInfo() on the right thread.

Call XmppSignalStrategy::SetAuthInfo() on the right thread.

BUG=123384
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132325

[Wez, 2012-04-13 22:40:52]

http://codereview.chromium.org/10081025/diff/1/remoting/host/remoting_me2me_h...
File remoting/host/remoting_me2me_host.cc (right):

http://codereview.chromium.org/10081025/diff/1/remoting/host/remoting_me2me_h...
remoting/host/remoting_me2me_host.cc:181:
base::Unretained(signal_strategy_.get()),
Looks like ChromotingContext gets torn down after SignalStrategy, so I don't
think you can safely use Unretained here.

[Jamie, 2012-04-13 22:41:08]

http://codereview.chromium.org/10081025/diff/1/remoting/host/remoting_me2me_h...
File remoting/host/remoting_me2me_host.cc (right):

http://codereview.chromium.org/10081025/diff/1/remoting/host/remoting_me2me_h...
remoting/host/remoting_me2me_host.cc:181:
base::Unretained(signal_strategy_.get()),
I think there's a race condition here. signal_strategy_ is declared after
context_ in the class definition, so the network thread will outlive it, making
this use of Unretained unsafe.

[Sergey Ulanov, 2012-04-13 23:43:50]

http://codereview.chromium.org/10081025/diff/1/remoting/host/remoting_me2me_h...
File remoting/host/remoting_me2me_host.cc (right):

http://codereview.chromium.org/10081025/diff/1/remoting/host/remoting_me2me_h...
remoting/host/remoting_me2me_host.cc:181:
base::Unretained(signal_strategy_.get()),
On 2012/04/13 22:41:08, Jamie wrote:
> I think there's a race condition here. signal_strategy_ is declared after
> context_ in the class definition, so the network thread will outlive it,
making
> this use of Unretained unsafe.

Yes, I realize this may be unsafe, but we never need to quit me2me host cleanly
anyway - Run() methods just call MessageLoop::Run() which runs until the process
is killed.
In either case, I plan to refactor this code and move OAuth refresh token
handling to SignalingConnector. This is just a quick and dirty fix to avoid
DCHECK.

[Jamie, 2012-04-13 23:51:00]

lgtm for the short term.

[Wez, 2012-04-13 23:52:34]

On 2012/04/13 23:51:00, Jamie wrote:
> lgtm for the short term.

LGTM++

[commit-bot: I haz the power, 2012-04-14 00:42:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10081025/1

[commit-bot: I haz the power, 2012-04-14 04:36:04]

Change committed as 132325