webkit/plugins/ppapi/ppb_video_decoder_impl.h - Issue 10081020: PPAPI: Make blocking completion callbacks work.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/plugins/ppapi/ppb_video_decoder_impl.h

Issue 10081020: PPAPI: Make blocking completion callbacks work. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: export AssertLockHeld Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webkit/plugins/ppapi/ppb_video_decoder_impl.h

diff --git a/webkit/plugins/ppapi/ppb_video_decoder_impl.h b/webkit/plugins/ppapi/ppb_video_decoder_impl.h

index 895874b3f4602a43c69b1ddf1e91a31ff5ef75a3..f82f7026a4b3c0f2cfea85100fb49ea8af8cf9f6 100644

--- a/webkit/plugins/ppapi/ppb_video_decoder_impl.h

+++ b/webkit/plugins/ppapi/ppb_video_decoder_impl.h

@@ -39,13 +39,16 @@ class PPB_VideoDecoder_Impl : public ::ppapi::PPB_VideoDecoder_Shared,

PP_VideoDecoder_Profile profile);

// PPB_VideoDecoder_API implementation.

- virtual int32_t Decode(const PP_VideoBitstreamBuffer_Dev* bitstream_buffer,

- PP_CompletionCallback callback) OVERRIDE;

+ virtual int32_t Decode(

+ const PP_VideoBitstreamBuffer_Dev* bitstream_buffer,

+ scoped_refptr< ::ppapi::TrackedCallback> callback) OVERRIDE;

virtual void AssignPictureBuffers(

uint32_t no_of_buffers, const PP_PictureBuffer_Dev* buffers) OVERRIDE;

virtual void ReusePictureBuffer(int32_t picture_buffer_id) OVERRIDE;

- virtual int32_t Flush(PP_CompletionCallback callback) OVERRIDE;

- virtual int32_t Reset(PP_CompletionCallback callback) OVERRIDE;

+ virtual int32_t Flush(

+ scoped_refptr< ::ppapi::TrackedCallback> callback) OVERRIDE;

+ virtual int32_t Reset(

+ scoped_refptr< ::ppapi::TrackedCallback> callback) OVERRIDE;

virtual void Destroy() OVERRIDE;

// media::VideoDecodeAccelerator::Client implementation.