PPAPI: Make blocking completion callbacks work.

ppapi/thunk/ppb_graphics_2d_api.h

Index: ppapi/thunk/ppb_graphics_2d_api.h
diff --git a/ppapi/thunk/ppb_graphics_2d_api.h b/ppapi/thunk/ppb_graphics_2d_api.h
index 7b74cb3667fd95597c96dd8304942cd7b92d29c8..320297b781b1e523a96c411a4efdfa7900998f32 100644
--- a/ppapi/thunk/ppb_graphics_2d_api.h
+++ b/ppapi/thunk/ppb_graphics_2d_api.h
@@ -1,7 +1,8 @@
-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include "base/memory/ref_counted.h"
 #include "ppapi/c/pp_bool.h"
 #include "ppapi/c/pp_completion_callback.h"
 #include "ppapi/c/pp_point.h"
@@ -10,6 +11,9 @@
 #include "ppapi/c/pp_size.h"
 
 namespace ppapi {
+
+class TrackedCallback;
+
 namespace thunk {
 
 class PPB_Graphics2D_API {
@@ -23,7 +27,7 @@ class PPB_Graphics2D_API {
   virtual void Scroll(const PP_Rect* clip_rect,
                       const PP_Point* amount) = 0;
   virtual void ReplaceContents(PP_Resource image_data) = 0;
-  virtual int32_t Flush(PP_CompletionCallback callback) = 0;
+  virtual int32_t Flush(scoped_refptr<TrackedCallback> callback) = 0;

[brettw, 2012/05/20 17:46:46]

I hate to bring this up, but is it necessary to pass these as scoped_refptrs as
input args? This will cause an extra threadsafe addref + release for every call
and I think normally we just pass as normal poitners. If the callee wants to
keep a ref, they're welcome to, but the caller will have to keep a ref no matter
what.

[dmichael (off chromium), 2012/05/22 18:08:39]

Aw, this is why I started with a typedef :-p

I like using "scoped_refptr" in the signature to make it clear that it's a
ref-counted object (otherwise ownership is really unclear). And I'd ultimately
like to make scoped_refptr not automatically convert to a raw pointer. How would
you feel about passing by const-ref?

[dmichael (off chromium), 2012/06/22 18:14:05]

^^^^^ Just wanted to point this comment out again, since it's been forever...  I
can change to passing by const-ref to avoid the extra ref-counting, if you like.
Otherwise, I'd prefer to leave it be.

 };
 
 }  // namespace thunk