Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: ppapi/thunk/ppb_file_io_trusted_thunk.cc

Issue 10081020: PPAPI: Make blocking completion callbacks work. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Updated TestURLLoader to test blocking callbacks. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/thunk/ppb_file_io_trusted_thunk.cc
diff --git a/ppapi/thunk/ppb_file_io_trusted_thunk.cc b/ppapi/thunk/ppb_file_io_trusted_thunk.cc
index c291ec8c9869171687990393b13dc9dfee2f0669..4e808dbffc1fc3b81a4bbcfab2524875365c50a8 100644
--- a/ppapi/thunk/ppb_file_io_trusted_thunk.cc
+++ b/ppapi/thunk/ppb_file_io_trusted_thunk.cc
@@ -21,7 +21,7 @@ int32_t GetOSFileDescriptor(PP_Resource file_io) {
EnterFileIO enter(file_io, true);
if (enter.failed())
return enter.retval();
- return enter.SetResult(enter.object()->GetOSFileDescriptor());
dmichael (off chromium) 2012/04/19 20:02:00 With no callback, it doesn't make sense to call Se
+ return enter.object()->GetOSFileDescriptor();
}
int32_t WillWrite(PP_Resource file_io,
@@ -32,7 +32,7 @@ int32_t WillWrite(PP_Resource file_io,
if (enter.failed())
return enter.retval();
return enter.SetResult(enter.object()->WillWrite(offset, bytes_to_write,
- callback));
+ enter.callback()));
}
int32_t WillSetLength(PP_Resource file_io,
@@ -41,7 +41,8 @@ int32_t WillSetLength(PP_Resource file_io,
EnterFileIO enter(file_io, callback, true);
if (enter.failed())
return enter.retval();
- return enter.SetResult(enter.object()->WillSetLength(length, callback));
+ return enter.SetResult(enter.object()->WillSetLength(length,
+ enter.callback()));
}
const PPB_FileIOTrusted g_ppb_file_io_trusted_thunk = {

Powered by Google App Engine
This is Rietveld 408576698