PPAPI: Make blocking completion callbacks work.

ppapi/shared_impl/ppb_file_io_shared.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ppapi/shared_impl/ppb_file_io_shared.h"
 
 #include <string.h>
 
 #include "base/bind.h"
 #include "base/logging.h"
@@ skipping 40 matching lines @@
 
 PPB_FileIO_Shared::~PPB_FileIO_Shared() {
 }
 
 thunk::PPB_FileIO_API* PPB_FileIO_Shared::AsPPB_FileIO_API() {
   return this;
 }
 
 int32_t PPB_FileIO_Shared::Open(PP_Resource file_ref,
                                 int32_t open_flags,
-                                PP_CompletionCallback callback) {
+                                scoped_refptr<TrackedCallback> callback) {
   EnterResourceNoLock<PPB_FileRef_API> enter(file_ref, true);
   if (enter.failed())
     return PP_ERROR_BADRESOURCE;
 
-  int32_t rv = CommonCallValidation(false, OPERATION_EXCLUSIVE, callback);
+  int32_t rv = CommonCallValidation(false, OPERATION_EXCLUSIVE);
   if (rv != PP_OK)
     return rv;
 
   PP_FileSystemType type = enter.object()->GetFileSystemType();
   if (type != PP_FILESYSTEMTYPE_LOCALPERSISTENT &&
       type != PP_FILESYSTEMTYPE_LOCALTEMPORARY &&
       type != PP_FILESYSTEMTYPE_EXTERNAL)
     return PP_ERROR_FAILED;
   file_system_type_ = type;
 
   return OpenValidated(file_ref, enter.object(), open_flags, callback);
 }
 
 int32_t PPB_FileIO_Shared::Query(PP_FileInfo* info,
-                                 PP_CompletionCallback callback) {
-  int32_t rv = CommonCallValidation(true, OPERATION_EXCLUSIVE, callback);
+                                 scoped_refptr<TrackedCallback> callback) {
+  int32_t rv = CommonCallValidation(true, OPERATION_EXCLUSIVE);
   if (rv != PP_OK)
     return rv;
   if (!info)
     return PP_ERROR_BADARGUMENT;
   return QueryValidated(info, callback);
 }
 
 int32_t PPB_FileIO_Shared::Touch(PP_Time last_access_time,
                                  PP_Time last_modified_time,
-                                 PP_CompletionCallback callback) {
-  int32_t rv = CommonCallValidation(true, OPERATION_EXCLUSIVE, callback);
+                                 scoped_refptr<TrackedCallback> callback) {
+  int32_t rv = CommonCallValidation(true, OPERATION_EXCLUSIVE);
   if (rv != PP_OK)
     return rv;
   return TouchValidated(last_access_time, last_modified_time, callback);
 }
 
 int32_t PPB_FileIO_Shared::Read(int64_t offset,
                                 char* buffer,
                                 int32_t bytes_to_read,
-                                PP_CompletionCallback callback) {
-  int32_t rv = CommonCallValidation(true, OPERATION_READ, callback);
+                                scoped_refptr<TrackedCallback> callback) {
+  int32_t rv = CommonCallValidation(true, OPERATION_READ);
   if (rv != PP_OK)
     return rv;
   return ReadValidated(offset, buffer, bytes_to_read, callback);
 }
 
 int32_t PPB_FileIO_Shared::Write(int64_t offset,
                                  const char* buffer,
                                  int32_t bytes_to_write,
-                                 PP_CompletionCallback callback) {
-  int32_t rv = CommonCallValidation(true, OPERATION_WRITE, callback);
+                                 scoped_refptr<TrackedCallback> callback) {
+  int32_t rv = CommonCallValidation(true, OPERATION_WRITE);
   if (rv != PP_OK)
     return rv;
   return WriteValidated(offset, buffer, bytes_to_write, callback);
 }
 
 int32_t PPB_FileIO_Shared::SetLength(int64_t length,
-                                     PP_CompletionCallback callback) {
-  int32_t rv = CommonCallValidation(true, OPERATION_EXCLUSIVE, callback);
+                                     scoped_refptr<TrackedCallback> callback) {
+  int32_t rv = CommonCallValidation(true, OPERATION_EXCLUSIVE);
   if (rv != PP_OK)
     return rv;
   return SetLengthValidated(length, callback);
 }
 
-int32_t PPB_FileIO_Shared::Flush(PP_CompletionCallback callback) {
-  int32_t rv = CommonCallValidation(true, OPERATION_EXCLUSIVE, callback);
+int32_t PPB_FileIO_Shared::Flush(scoped_refptr<TrackedCallback> callback) {
+  int32_t rv = CommonCallValidation(true, OPERATION_EXCLUSIVE);
   if (rv != PP_OK)
     return rv;
   return FlushValidated(callback);
 }
 
 void PPB_FileIO_Shared::ExecuteGeneralCallback(int32_t pp_error) {
   RunAndRemoveFirstPendingCallback(pp_error);
 }
 
 void PPB_FileIO_Shared::ExecuteOpenFileCallback(int32_t pp_error) {
@@ skipping 23 matching lines @@
   // The result code contains the number of bytes if it's positive.
   if (pp_error > 0) {
     char* read_buffer = callbacks_.front().read_buffer;
     DCHECK(data);
     DCHECK(read_buffer);
     memcpy(read_buffer, data, pp_error);
   }
   RunAndRemoveFirstPendingCallback(pp_error);
 }
 
-int32_t PPB_FileIO_Shared::CommonCallValidation(
-    bool should_be_open,
-    OperationType new_op,
-    PP_CompletionCallback callback) {
+int32_t PPB_FileIO_Shared::CommonCallValidation(bool should_be_open,
+                                                OperationType new_op) {
   // Only asynchronous operation is supported.
-  if (!callback.func)
-    return PP_ERROR_BLOCKS_MAIN_THREAD;
-
   if (should_be_open) {
     if (!file_open_)
       return PP_ERROR_FAILED;
   } else {
     if (file_open_)
       return PP_ERROR_FAILED;
   }
 
   if (pending_op_ != OPERATION_NONE &&
       (pending_op_ != new_op || pending_op_ == OPERATION_EXCLUSIVE)) {
     return PP_ERROR_INPROGRESS;
   }
 
   return PP_OK;
 }
 
-void PPB_FileIO_Shared::RegisterCallback(OperationType op,
-                                         PP_CompletionCallback callback,
-                                         char* read_buffer,
-                                         PP_FileInfo* info) {
-  DCHECK(callback.func);
+void PPB_FileIO_Shared::RegisterCallback(
+    OperationType op,
+    scoped_refptr<TrackedCallback> callback,
+    char* read_buffer,
+    PP_FileInfo* info) {
   DCHECK(pending_op_ == OPERATION_NONE ||
          (pending_op_ != OPERATION_EXCLUSIVE && pending_op_ == op));
 
   CallbackEntry entry;
-  entry.callback = new TrackedCallback(this, callback);
+  entry.callback = callback;
   entry.read_buffer = read_buffer;
   entry.info = info;
   callbacks_.push_back(entry);
 
   pending_op_ = op;
 }
 
 void PPB_FileIO_Shared::RunAndRemoveFirstPendingCallback(int32_t result) {
   DCHECK(!callbacks_.empty());
 
   CallbackEntry front = callbacks_.front();
   callbacks_.pop_front();
   if (callbacks_.empty())
     pending_op_ = OPERATION_NONE;
 
   front.callback->Run(result);
 }
 
 }  // namespace ppapi