Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 10081007: Remove unused and unnecessary constructor from PlatformFont classes. (Closed)

Created:
8 years, 8 months ago by Alexei Svitkine (slow)
Modified:
8 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Remove unused and unnecessary constructor from PlatformFont classes. These are not used by Font since it keeps a scoped_refptr to PlatformFont. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132229

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -37 lines) Patch
M ui/gfx/platform_font.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/platform_font_android.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/gfx/platform_font_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/platform_font_mac.mm View 2 chunks +0 lines, -8 lines 0 comments Download
M ui/gfx/platform_font_pango.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/platform_font_pango.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M ui/gfx/platform_font_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/platform_font_win.cc View 2 chunks +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alexei Svitkine (slow)
8 years, 8 months ago (2012-04-13 16:49:15 UTC) #1
sky
LGTM
8 years, 8 months ago (2012-04-13 16:55:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/10081007/1
8 years, 8 months ago (2012-04-13 17:23:08 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-13 18:54:21 UTC) #4
Change committed as 132229

Powered by Google App Engine
This is Rietveld 408576698