Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 10080014: Fix a bug in IDL parsing related to arrays of callbacks. (Closed)

Created:
8 years, 8 months ago by asargent_no_longer_on_chrome
Modified:
8 years, 8 months ago
Reviewers:
miket_OOO
CC:
chromium-reviews, pam+watch_chromium.org, Matt Perry
Visibility:
Public.

Description

Fix a bug in IDL parsing related to arrays of callbacks. Also rename the 'refs' parameter to 'callbacks' to make the code a little bit more clear, since 'refs' was only used to store callback information. Matt noticed this bug after I landed https://chromiumcodereview.appspot.com/10054039/ It turns out the the rest of the JSON compiler infrastructure doesn't actually support arrays of functions, but at least the IDL will generate the right JSON in this case. BUG=none TEST=included unit test should pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132430

Patch Set 1 #

Patch Set 2 : added in test file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -18 lines) Patch
M tools/json_schema_compiler/idl_schema.py View 11 chunks +32 lines, -18 lines 0 comments Download
M tools/json_schema_compiler/idl_schema_test.py View 1 chunk +8 lines, -0 lines 0 comments Download
A tools/json_schema_compiler/test/idl_callback_arrays.idl View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
asargent_no_longer_on_chrome
8 years, 8 months ago (2012-04-13 20:57:26 UTC) #1
miket_OOO
lgtm
8 years, 8 months ago (2012-04-13 21:04:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/10080014/1001
8 years, 8 months ago (2012-04-13 21:05:35 UTC) #3
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
8 years, 8 months ago (2012-04-13 22:37:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/10080014/1001
8 years, 8 months ago (2012-04-13 22:48:36 UTC) #5
commit-bot: I haz the power
Try job failure for 10080014-1001 (retry) on mac_rel for step "browser_tests". It's a second try, ...
8 years, 8 months ago (2012-04-14 00:46:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asargent@chromium.org/10080014/1001
8 years, 8 months ago (2012-04-16 16:40:25 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-04-16 18:16:16 UTC) #8
Change committed as 132430

Powered by Google App Engine
This is Rietveld 408576698