Issue 10080013: Makes the code simpler by automatically deducing the root directory to use.

Issue 10080013: Makes the code simpler by automatically deducing the root directory to use. (Closed)

Created:
8 years, 8 months ago by M-A Ruel

Modified:
8 years, 8 months ago

Reviewers:
Nicolas Sylvain, nsylvain, Marc-Antoine Ruel (Google)

CC:
chromium-reviews, pam+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Makes the code simpler by automatically deducing the root directory to use. Make the code more testable by separating argument parsing from main(). R=nsylvain@chromium.org BUG=98834 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133457

Patch Set 1 #

Patch Set 2 : Fix file sharing on windows #

Total comments: 5

Patch Set 3 : Address review comment #

Total comments: 2

Patch Set 4 : Removed comment #

Patch Set 5 : Rebase #

Patch Set 6 : Rebase against 10139020 #

Patch Set 7 : Now completely working on windows #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+252 lines, -156 lines)			Patch
M	third_party/cacheinvalidation/README.chromium	View	1 2 3 4 5 6	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/cacheinvalidation/cacheinvalidation.gyp	View	1 2 3 4 5 6	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/isolate/isolate.py	View	1 2 3 4 5 6	6 chunks	+167 lines, -147 lines	0 comments	Download
M	tools/isolate/isolate_smoke_test.py	View	1 2 3 4 5	6 chunks	+15 lines, -7 lines	0 comments	Download
M	tools/isolate/isolate_test.py	View	1 2 3 4 5	2 chunks	+69 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

nsylvain

lgtm, but not fully understood yet. Most of my comments were on code that already ...

8 years, 8 months ago (2012-04-14 21:49:02 UTC) #2

Marc-Antoine Ruel (Google)

ptal https://chromiumcodereview.appspot.com/10080013/diff/2001/tools/isolate/isolate.py File tools/isolate/isolate.py (right): https://chromiumcodereview.appspot.com/10080013/diff/2001/tools/isolate/isolate.py#newcode288 tools/isolate/isolate.py:288: mode_fn = getattr(sys.modules[__name__], 'MODE' + mode) On 2012/04/14 ...

8 years, 8 months ago (2012-04-14 23:51:24 UTC) #3

nsylvain

lgtm https://chromiumcodereview.appspot.com/10080013/diff/4001/tools/isolate/isolate.py File tools/isolate/isolate.py (right): https://chromiumcodereview.appspot.com/10080013/diff/4001/tools/isolate/isolate.py#newcode289 tools/isolate/isolate.py:289: #mode_fn = getattr(sys.modules[__name__], 'MODE' + mode) remove? https://chromiumcodereview.appspot.com/10080013/diff/4001/tools/isolate/isolate_smoke_test.py ...

8 years, 8 months ago (2012-04-16 15:51:42 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10080013/16001

8 years, 8 months ago (2012-04-23 14:40:10 UTC) #5

Change committed as 133457

Expand Messages | Collapse Messages