webkit/blob/local_file_reader.h - Issue 10080001: Reland 132134 with memory fix - Use LocalFileReader in FileSystemURLRequestJob

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/blob/local_file_reader.h

Issue 10080001: Reland 132134 with memory fix - Use LocalFileReader in FileSystemURLRequestJob (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Read return value fix Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/blob/local_file_reader.h

diff --git a/webkit/blob/local_file_reader.h b/webkit/blob/local_file_reader.h

index 704f56109eb7b71a466dc5d8ee9df55710c409cd..2b2c67e01196284b43dda99fb05f8fdcdc8b42c9 100644

--- a/webkit/blob/local_file_reader.h

+++ b/webkit/blob/local_file_reader.h

@@ -34,7 +34,9 @@ class BLOB_EXPORT LocalFileReader {

// Creates a new FileReader for a local file |file_path|.

// |initial_offset| specifies the offset in the file where the first read

- // should start.

+ // should start. If the given offset is out of the file range any

+ // read operation may error out with net::ERR_REQUEST_RANGE_NOT_SATISFIABLE.

+ //

// |expected_modification_time| specifies the expected last modification

// If the value is non-null, the reader will check the underlying file's

// actual modification time to see if the file has been modified, and if

« no previous file with comments | « webkit/blob/blob_url_request_job.cc ('k') | webkit/blob/local_file_reader.cc » ('j') | no next file with comments »