Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6005)

Unified Diff: chrome/browser/metrics/metrics_service.h

Issue 10078017: Added asynchronous notification of readiness to the StatisticsProvider, and (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Load hardware_class when available without delaying init of MetricsService Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/metrics_service.h
diff --git a/chrome/browser/metrics/metrics_service.h b/chrome/browser/metrics/metrics_service.h
index 229921de4fbdfaf848b283a4bde64ce88dd34495..b57318840775fef9dd20fe9563d0d76ac8da025c 100644
--- a/chrome/browser/metrics/metrics_service.h
+++ b/chrome/browser/metrics/metrics_service.h
@@ -152,14 +152,12 @@ class MetricsService : public content::NotificationObserver,
NEED_TO_SHUTDOWN = ~CLEANLY_SHUTDOWN
};
- // First part of the init task. Called on the FILE thread to load hardware
- // class information.
- static void InitTaskGetHardwareClass(base::WeakPtr<MetricsService> self,
- base::MessageLoopProxy* target_loop);
-
- // Callback from InitTaskGetHardwareClass() that continues the init task by
- // loading plugin information.
- void OnInitTaskGotHardwareClass(const std::string& hardware_class);
+ // Callback for the StatisticsProvider to signal that hardware data has been
+ // loaded. Retrieves the hardware class and stores it in hardware_class_.
+ void OnStatisticsProviderReady();
+
+ // First part of the init task that starts loading plugin info asynchronously.
+ void InitTaskGetPluginInfo();
// Callback from PluginService::GetPlugins() that moves the state to
// INIT_TASK_DONE.

Powered by Google App Engine
This is Rietveld 408576698