Added asynchronous notification of readiness to the StatisticsProvider, and

chrome/browser/chromeos/system/statistics_provider.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_SYSTEM_STATISTICS_PROVIDER_H_
 #define CHROME_BROWSER_CHROMEOS_SYSTEM_STATISTICS_PROVIDER_H_
 #pragma once
 
 #include <string>
 
+#include "base/callback.h"
+
 namespace chromeos {
 namespace system {
 
 // This interface provides access to Chrome OS statistics.
 class StatisticsProvider {
  public:
   // Retrieve the named machine statistic (e.g. "hardware_class").
   // This does not update the statistcs. If the |name| is not set, |result|
-  // preserves old value.
+  // preserves the previous value.

[Ilya Sherman, 2012/04/20 21:18:37]

nit: Perhaps "is unchanged" rather than "preserves the previous value"?  I had
to read this a couple of times to figure out that this just meant that if |name|
is empty then this method is a no-op.  (In fact, could that just be a DCHECK
instead?)

[Joao da Silva, 2012/04/23 09:36:50]

Rephrased as suggested. It's not a DCHECK, since it's valid to query for names
that aren't present on some machines. The return value indicates whether the
requested name was found or not.

+  // This call may block if the statistics aren't ready yet, up to a timeout;
+  // it may also fail because the statistics weren't ready before the timeout.
+  // To make sure this won't block nor fail, invoke GetMachineStatistic() after
+  // WhenReady() has invoked its callback.
   virtual bool GetMachineStatistic(const std::string& name,
                                    std::string* result) = 0;
 
+  // Invokes |callback| on the UI loop once the statistics have been loaded.
+  // |callback| is immediately posted to the UI loop if the statistics are
+  // already available.
+  virtual void WhenReady(const base::Closure& callback) = 0;
+
   static StatisticsProvider* GetInstance();
 
  protected:
   virtual ~StatisticsProvider() {}
 };
 
 }  // namespace system
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_CHROMEOS_SYSTEM_STATISTICS_PROVIDER_H_