Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Unified Diff: chromeos/dbus/flimflam_device_client.h

Issue 10078007: Add chromeos::FlimflamDeviceClient::CallGetPropertiesAndBlock/CallAddIPConfigAndBlock (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add TODO Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/flimflam_client_helper.cc ('k') | chromeos/dbus/flimflam_device_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/flimflam_device_client.h
diff --git a/chromeos/dbus/flimflam_device_client.h b/chromeos/dbus/flimflam_device_client.h
index 722f0c36f1b0dc2f12a6719965489fa40ca916a6..451a031f8f29e0f543decb5c364da3d0ef37f469 100644
--- a/chromeos/dbus/flimflam_device_client.h
+++ b/chromeos/dbus/flimflam_device_client.h
@@ -60,6 +60,14 @@ class CHROMEOS_EXPORT FlimflamDeviceClient {
virtual void GetProperties(const dbus::ObjectPath& device_path,
const DictionaryValueCallback& callback) = 0;
+ // DEPRECATED DO NOT USE: Calls GetProperties method and blocks until the
+ // method call finishes. The caller is responsible to delete the result.
+ // Thie method returns NULL when method call fails.
+ //
+ // TODO(hashimoto): Refactor CrosGetDeviceNetworkList and remove this method.
+ virtual base::DictionaryValue* CallGetPropertiesAndBlock(
+ const dbus::ObjectPath& device_path) = 0;
+
// Calls ProposeScan method.
// |callback| is called after the method call finishes.
virtual void ProposeScan(const dbus::ObjectPath& device_path,
@@ -84,6 +92,15 @@ class CHROMEOS_EXPORT FlimflamDeviceClient {
const std::string& method,
const ObjectPathCallback& callback) = 0;
+ // DEPRECATED DO NOT USE: Calls AddIPConfig method and blocks until the method
+ // call finishes.
+ // This method returns an empty path when method call fails.
+ //
+ // TODO(hashimoto): Refactor CrosAddIPConfig and remove this method.
+ virtual dbus::ObjectPath CallAddIPConfigAndBlock(
+ const dbus::ObjectPath& device_path,
+ const std::string& method) = 0;
+
// Calls RequirePin method.
// |callback| is called after the method call finishes.
virtual void RequirePin(const dbus::ObjectPath& device_path,
« no previous file with comments | « chromeos/dbus/flimflam_client_helper.cc ('k') | chromeos/dbus/flimflam_device_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698