Issue 10078007: Add chromeos::FlimflamDeviceClient::CallGetPropertiesAndBlock/CallAddIPConfigAndBlock

Issue 10078007: Add chromeos::FlimflamDeviceClient::CallGetPropertiesAndBlock/CallAddIPConfigAndBlock (Closed)

Created:
8 years, 8 months ago by hashimoto

Modified:
8 years, 8 months ago

Reviewers:
stevenjb

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add chromeos::FlimflamDeviceClient::CallGetPropertiesAndBlock/CallAddIPConfigAndBlock BUG=chromium-os:16557 TEST=chromeos_unittests --gtest_filter="FlimflamDeviceClientTest.*" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133150

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add TODO #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+137 lines, -0 lines)			Patch
M	chromeos/dbus/flimflam_client_helper.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chromeos/dbus/flimflam_client_helper.cc	View		1 chunk	+15 lines, -0 lines	0 comments	Download
M	chromeos/dbus/flimflam_device_client.h	View	1	2 chunks	+17 lines, -0 lines	0 comments	Download
M	chromeos/dbus/flimflam_device_client.cc	View		4 chunks	+33 lines, -0 lines	0 comments	Download
M	chromeos/dbus/flimflam_device_client_unittest.cc	View		2 chunks	+64 lines, -0 lines	0 comments	Download
M	chromeos/dbus/mock_flimflam_device_client.h	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

stevenjb

lgtm http://codereview.chromium.org/10078007/diff/1/chromeos/dbus/flimflam_device_client.h File chromeos/dbus/flimflam_device_client.h (right): http://codereview.chromium.org/10078007/diff/1/chromeos/dbus/flimflam_device_client.h#newcode65 chromeos/dbus/flimflam_device_client.h:65: // Thie method returns NULL when method call ...

8 years, 8 months ago (2012-04-19 16:47:00 UTC) #2

hashimoto

http://codereview.chromium.org/10078007/diff/1/chromeos/dbus/flimflam_device_client.h File chromeos/dbus/flimflam_device_client.h (right): http://codereview.chromium.org/10078007/diff/1/chromeos/dbus/flimflam_device_client.h#newcode65 chromeos/dbus/flimflam_device_client.h:65: // Thie method returns NULL when method call fails. ...

8 years, 8 months ago (2012-04-20 02:31:22 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/10078007/6001

8 years, 8 months ago (2012-04-20 02:31:35 UTC) #4

Change committed as 133150

Expand Messages | Collapse Messages