Issue 10078002: aura: Add flush() to make sure delete operations make it through when we intend.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10078002: aura: Add flush() to make sure delete operations make it through when we intend. (Closed)

Created:
8 years, 8 months ago by piman

Modified:
8 years, 8 months ago

Reviewers:
mazda, Ben Goodger (Google), jonathan.backer

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

aura: Add flush() to make sure delete operations make it through when we intend. Resource deletion doesn't force a flush, so for textures that are deleted on a little-used shared context, the delete command may sit in the command buffer for arbitrary long. This fixes it. BUG=123933 TEST=chrome/aura, open many tabs, close all of them, check that GPU memory is reclaimed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133017

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -1 line)			Patch
	M	content/browser/renderer_host/image_transport_factory.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	content/common/gpu/client/gl_helper.cc	View		5 chunks	+19 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

piman

mazda: gl_helper.cc backer: image_transport_factory.cc ben: OWNERS for content/browser

8 years, 8 months ago (2012-04-19 03:20:04 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/10078002/1

8 years, 8 months ago (2012-04-19 16:26:14 UTC) #5

Change committed as 133017

Expand Messages | Collapse Messages