Issue 10077001: [UMA] Use proper C++ objects to serialize tracked_objects across process boundaries.

Issue 10077001: [UMA] Use proper C++ objects to serialize tracked_objects across process boundaries. (Closed)

Created:
8 years, 8 months ago by Ilya Sherman

Modified:
8 years, 8 months ago

Reviewers:
James Hawkins, eroman, jam, jar (doing other things), awong

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, MAD, simonmorris+watch_chromium.org, jar (doing other things), hclam+watch_chromium.org, wez+watch_chromium.org, erikwright (departed), amit, sanjeevr, jam, garykac+watch_chromium.org, joi+watch-content_chromium.org, arv (Not doing code reviews), darin-cc_chromium.org, brettw-cc_chromium.org, alexeypa+watch_chromium.org, Ilya Sherman, sergeyu+watch_chromium.org, lambroslambrou+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[UMA] Use proper C++ objects to serialize tracked_objects across process boundaries. See https://chromiumcodereview.appspot.com/9702014/ for the original code review. Uploading to a new issue due to an AppEngine error... BUG=103480 TEST=none (refactoring, no functional change expected) TBR=jam@chromium.org,jar@chromium.org,eroman@chromium.org,jhawkins@chromium.org,ajwong@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132109

Patch Set 1 #

Patch Set 2 : Fix yet another IWYU in the chromeos/ code... #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1145 lines, -1049 lines)			Patch
M	base/location.h	View		3 chunks	+14 lines, -8 lines	0 comments	Download
M	base/location.cc	View		2 chunks	+13 lines, -11 lines	0 comments	Download
M	base/tracked_objects.h	View		14 chunks	+118 lines, -116 lines	0 comments	Download
M	base/tracked_objects.cc	View		9 chunks	+132 lines, -146 lines	0 comments	Download
M	base/tracked_objects_unittest.cc	View		13 chunks	+287 lines, -529 lines	0 comments	Download
M	chrome/browser/metrics/tracking_synchronizer.h	View		6 chunks	+15 lines, -31 lines	0 comments	Download
M	chrome/browser/metrics/tracking_synchronizer.cc	View		11 chunks	+60 lines, -66 lines	0 comments	Download
A	chrome/browser/metrics/tracking_synchronizer_observer.h	View		1 chunk	+42 lines, -0 lines	0 comments	Download
M	chrome/browser/resources/profiler/profiler.js	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/task_profiler/task_profiler_data_serializer.h	View		1 chunk	+22 lines, -1 line	0 comments	Download
M	chrome/browser/task_profiler/task_profiler_data_serializer.cc	View		2 chunks	+120 lines, -5 lines	0 comments	Download
A	chrome/browser/task_profiler/task_profiler_data_serializer_unittest.cc	View		1 chunk	+161 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/profiler_ui.h	View		2 chunks	+9 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/webui/profiler_ui.cc	View		4 chunks	+19 lines, -11 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chromeos/dbus/flimflam_client_unittest_base.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chromeos/dbus/flimflam_ipconfig_client.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chromeos/dbus/flimflam_manager_client.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chromeos/dbus/flimflam_manager_client_unittest.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	chromeos/dbus/flimflam_network_client_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chromeos/dbus/flimflam_profile_client.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/browser_child_process_host_impl.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/profiler_controller_impl.h	View		4 chunks	+18 lines, -16 lines	0 comments	Download
M	content/browser/profiler_controller_impl.cc	View		6 chunks	+15 lines, -44 lines	0 comments	Download
M	content/browser/profiler_message_filter.h	View		2 chunks	+14 lines, -7 lines	0 comments	Download
M	content/browser/profiler_message_filter.cc	View		2 chunks	+8 lines, -10 lines	0 comments	Download
M	content/browser/renderer_host/render_process_host_impl.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	content/common/child_process_messages.h	View		3 chunks	+42 lines, -5 lines	0 comments	Download
M	content/common/child_thread.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	content/common/child_thread.cc	View		3 chunks	+9 lines, -13 lines	0 comments	Download
M	content/public/browser/profiler_controller.h	View		1 chunk	+1 line, -7 lines	0 comments	Download
M	content/public/browser/profiler_subscriber.h	View		2 chunks	+8 lines, -6 lines	0 comments	Download
M	remoting/host/plugin/host_script_object.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/10077001/1

8 years, 8 months ago (2012-04-12 22:06:08 UTC) #1

commit-bot: I haz the power

Try job failure for 10077001-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...

8 years, 8 months ago (2012-04-12 22:30:30 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/10077001/6002

8 years, 8 months ago (2012-04-12 22:58:29 UTC) #3

Change committed as 132109

Expand Messages | Collapse Messages