Fix memory leak caused by Rules Registries

chrome/browser/extensions/extension_system.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_system.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/string_tokenizer.h"
@@ skipping 45 matching lines @@
 
 //
 // ExtensionSystemImpl::Shared
 //
 
 ExtensionSystemImpl::Shared::Shared(Profile* profile)
     : profile_(profile) {
 }
 
 ExtensionSystemImpl::Shared::~Shared() {
+  rules_registry_service_->Shutdown();

[Matt Perry, 2012/04/12 21:46:19]

When is this called? If it's during shutdown, then the IO thread might already
be gone, or in the process of shutting down, so that the posted tasks don't have
a chance to run.

[battre, 2012/04/12 22:20:52]

ExtensionSystemImpl::Shared is ref counted so it is deleted when the last
ExtensionSystemImpl is destroyed. This is triggered by
ProfileImpl::~ProfileImpl(). The Profile is owned by the ProfileManager which is
destroyed in BrowserProcessImpl before the IO thread is killed.

 }
 
 void ExtensionSystemImpl::Shared::InitPrefs() {
   bool extensions_disabled =
       profile_->GetPrefs()->GetBoolean(prefs::kDisableExtensions) ||
       CommandLine::ForCurrentProcess()->HasSwitch(switches::kDisableExtensions);
   extension_prefs_.reset(new ExtensionPrefs(
       profile_->GetPrefs(),
       profile_->GetPath().AppendASCII(ExtensionService::kInstallDirectoryName),
       ExtensionPrefValueMapFactory::GetForProfile(profile_)));
@@ skipping 234 matching lines @@
 }
 
 void ExtensionSystemImpl::UnregisterExtensionWithRequestContexts(
     const std::string& extension_id,
     const extension_misc::UnloadedExtensionReason reason) {
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&ExtensionInfoMap::RemoveExtension, info_map(),
                  extension_id, reason));
 }