Fix memory leak caused by Rules Registries

Fix memory leak caused by Rules Registries

This CL resets a scoped_ref_ptr to the WebRequestRulesRegistry in the ExtensionWebRequestEventRouter so that the WebRequestRulesRegistry can be freed.

BUG=122130
TEST=no


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132100

[battre, 2012-04-12 21:37:46]

Please review. Thanks.
Dominic

[Matt Perry, 2012-04-12 21:46:19]

https://chromiumcodereview.appspot.com/10076001/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/extension_system.cc (right):

https://chromiumcodereview.appspot.com/10076001/diff/1/chrome/browser/extensi...
chrome/browser/extensions/extension_system.cc:66:
rules_registry_service_->Shutdown();
When is this called? If it's during shutdown, then the IO thread might already
be gone, or in the process of shutting down, so that the posted tasks don't have
a chance to run.

[battre, 2012-04-12 22:20:52]

https://chromiumcodereview.appspot.com/10076001/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/extension_system.cc (right):

https://chromiumcodereview.appspot.com/10076001/diff/1/chrome/browser/extensi...
chrome/browser/extensions/extension_system.cc:66:
rules_registry_service_->Shutdown();
On 2012/04/12 21:46:19, Matt Perry wrote:
> When is this called? If it's during shutdown, then the IO thread might already
> be gone, or in the process of shutting down, so that the posted tasks don't
have
> a chance to run.

ExtensionSystemImpl::Shared is ref counted so it is deleted when the last
ExtensionSystemImpl is destroyed. This is triggered by
ProfileImpl::~ProfileImpl(). The Profile is owned by the ProfileManager which is
destroyed in BrowserProcessImpl before the IO thread is killed.

[Matt Perry, 2012-04-12 22:24:47]

OK LGTM

[commit-bot: I haz the power, 2012-04-12 22:31:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/battre@chromium.org/10076001/1

[commit-bot: I haz the power, 2012-04-13 00:12:06]

Change committed as 132100