Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1087)

Issue 10075002: Source major & minor versions from remoting, build & patch versions from Chrome. (Closed)

Created:
8 years, 8 months ago by Wez
Modified:
8 years, 8 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Source major & minor versions from remoting, build & patch versions from Chrome. The version number now follows the form major.minor.build.patch. Major & minor versions come from remoting/VERSION. Build & patch versions come from chrome/VERSION. BUG=122721 TEST=Remoting web-app, plugins and host component executables & DLLs have matching versions in the above form, if versioned. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132353

Patch Set 1 #

Patch Set 2 : Rebase. #

Total comments: 2

Patch Set 3 : Correct typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -32 lines) Patch
M remoting/VERSION View 1 chunk +0 lines, -2 lines 0 comments Download
M remoting/remoting.gyp View 1 2 9 chunks +19 lines, -11 lines 0 comments Download
M remoting/webapp/build-webapp.py View 4 chunks +9 lines, -18 lines 0 comments Download
M remoting/webapp/manifest.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
commit-bot: I haz the power
No reviewers yet.
8 years, 8 months ago (2012-04-14 01:06:34 UTC) #1
Wez
8 years, 8 months ago (2012-04-14 01:07:07 UTC) #2
alexeypa (please no reviews)
lgtm, one typo spotted. http://codereview.chromium.org/10075002/diff/9001/remoting/remoting.gyp File remoting/remoting.gyp (right): http://codereview.chromium.org/10075002/diff/9001/remoting/remoting.gyp#newcode319 remoting/remoting.gyp:319: # The substition strings are ...
8 years, 8 months ago (2012-04-14 04:08:56 UTC) #3
Wez
http://codereview.chromium.org/10075002/diff/9001/remoting/remoting.gyp File remoting/remoting.gyp (right): http://codereview.chromium.org/10075002/diff/9001/remoting/remoting.gyp#newcode319 remoting/remoting.gyp:319: # The substition strings are taken from: On 2012/04/14 ...
8 years, 8 months ago (2012-04-14 22:23:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10075002/14001
8 years, 8 months ago (2012-04-14 22:23:23 UTC) #5
commit-bot: I haz the power
Try job failure for 10075002-14001 (retry) on win_rel for step "update". It's a second try, ...
8 years, 8 months ago (2012-04-15 01:11:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10075002/14001
8 years, 8 months ago (2012-04-15 01:26:45 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-04-15 03:20:46 UTC) #8
Change committed as 132353

Powered by Google App Engine
This is Rietveld 408576698