Initial implementation of the ByteStream refactor.

content/browser/download/download_file_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/download/download_file_manager.h"
 
 #include "base/file_path.h"
 #include "base/file_util.h"
 #include "base/message_loop.h"
 #include "base/scoped_temp_dir.h"
 #include "base/string_number_conversions.h"
 #include "content/browser/browser_thread_impl.h"
-#include "content/browser/download/download_buffer.h"
 #include "content/browser/download/download_create_info.h"
 #include "content/browser/download/download_interrupt_reasons_impl.h"
 #include "content/browser/download/download_request_handle.h"
 #include "content/browser/download/mock_download_file.h"
 #include "content/public/browser/download_id.h"
 #include "content/test/mock_download_manager.h"
 #include "net/base/io_buffer.h"
 #include "net/base/net_errors.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 96 matching lines @@
   static const int32 kDummyDownloadId;
   static const int32 kDummyDownloadId2;
   static const int kDummyChildId;
   static const int kDummyRequestId;
 
   // We need a UI |BrowserThread| in order to destruct |download_manager_|,
   // which has trait |BrowserThread::DeleteOnUIThread|.  Without this,
   // calling Release() on |download_manager_| won't ever result in its
   // destructor being called and we get a leak.
   DownloadFileManagerTest()
-    : download_buffer_(new content::DownloadBuffer()),
-      ui_thread_(BrowserThread::UI, &loop_),
+    : ui_thread_(BrowserThread::UI, &loop_),
       file_thread_(BrowserThread::FILE, &loop_) {
   }
 
   ~DownloadFileManagerTest() {
   }
 
   virtual void SetUp() {
     download_manager_ = new MockDownloadManager();
     request_handle_.reset(new MockDownloadRequestHandle(download_manager_));
     download_file_factory_ = new MockDownloadFileFactory;
@@ skipping 47 matching lines @@
         .Times(AtLeast(1))
         .WillRepeatedly(Return(false));
     EXPECT_CALL(*download_manager_, StartDownload(id.local()));
 
     download_file_manager_->StartDownload(info, *request_handle_);
     ProcessAllPendingMessages();
 
     ClearExpectations(id);
   }
 
-  // Creates a new |net::IOBuffer| of size |length| with |data|, and attaches
-  // it to the download buffer.
-  bool UpdateBuffer(const char* data, size_t length) {
-    // We are passing ownership of this buffer to the download file manager.
-    // NOTE: we are padding io_buffer with one extra character so that the
-    // mock testing framework can treat it as a NULL-delimited string.
-    net::IOBuffer* io_buffer = new net::IOBuffer(length + 1);
-    // We need |AddRef()| because we do a |Release()| in |UpdateDownload()|.
-    io_buffer->AddRef();
-    memcpy(io_buffer->data(), data, length);
-    io_buffer->data()[length] = 0;
-
-    download_buffer_->AddData(io_buffer, length);
-
-    return true;
-  }
-
-  // Updates the download file.
-  // |id| is the download ID of the download file.
-  // |data| is the buffer containing the data.
-  // |length| is the length of the data buffer.
-  // |error_to_insert| is the error to simulate.  For no error, use net::OK.
-  void UpdateDownload(const DownloadId& id,
-                      const char* data,
-                      size_t length,
-                      net::Error error_to_insert) {
-    // Expected call sequence:
-    //  Create DownloadBuffer
-    //  UpdateDownload
-    //    GetDownloadFile
-    //    DownloadFile::AppendDataToFile
-    //
-    //    On error:
-    //      DownloadFile::GetDownloadManager
-    //      DownloadFile::BytesSoFar
-    //      CancelDownload
-    //  Process one message in the message loop
-    //      DownloadManager::OnDownloadInterrupted
-    EXPECT_TRUE(UpdateBuffer(data, length));
-    MockDownloadFile* file = download_file_factory_->GetExistingFile(id);
-    ASSERT_TRUE(file != NULL);
-    byte_count_[id] += length;
-
-    // Make sure our comparison string is NULL-terminated.
-    char* expected_data = new char[length + 1];
-    memcpy(expected_data, data, length);
-    expected_data[length] = 0;
-
-    EXPECT_CALL(*file, AppendDataToFile(StrEq(expected_data), length))
-        .Times(1)
-        .WillOnce(Return(error_to_insert));
-
-    if (error_to_insert != net::OK) {
-      EXPECT_CALL(*file, GetDownloadManager())
-          .Times(AtLeast(1));
-      EXPECT_CALL(*file, BytesSoFar())
-          .Times(AtLeast(1))
-          .WillRepeatedly(Return(byte_count_[id]));
-      EXPECT_CALL(*file, GetHashState())
-          .Times(AtLeast(1));
-      EXPECT_CALL(*file, Cancel());
-    }
-
-    download_file_manager_->UpdateDownload(id, download_buffer_.get());
-
-    if (error_to_insert != net::OK) {
-      EXPECT_CALL(*download_manager_,
-          OnDownloadInterrupted(
-              id.local(),
-              byte_count_[id],
-              "",
-              content::ConvertNetErrorToInterruptReason(
-                  error_to_insert, content::DOWNLOAD_INTERRUPT_FROM_DISK)));
-
-      ProcessAllPendingMessages();
-      ++error_count_[id];
-    }
-
-    ClearExpectations(id);
-    delete [] expected_data;
-  }
-
   // Renames the download file.
   // |id|           is the download ID of the download file.
   // |new_path|     is the new file path.
   // |unique_path|  is the actual path that the download file will be
   //                renamed to. If there is an existing file at
   //                |new_path| and |replace| is false, then |new_path|
   //                will be uniquified.
   // |rename_error| is the error to inject.  For no error, use net::OK.
   // |state|        whether we are renaming an in-progress download or a
   //                completed download.
@@ skipping 97 matching lines @@
     if (reason == content::DOWNLOAD_INTERRUPT_REASON_NONE) {
       EXPECT_CALL(*file, GetHash(_))
           .WillOnce(Return(false));
     } else {
       EXPECT_CALL(*file, GetHashState());
     }
     EXPECT_CALL(*file, BytesSoFar())
         .Times(AtLeast(1))
         .WillRepeatedly(Return(byte_count_[id]));
 
-    download_file_manager_->OnResponseCompleted(id, reason, security_string);
-
     if (reason == content::DOWNLOAD_INTERRUPT_REASON_NONE) {
       EXPECT_CALL(*download_manager_,
                   OnResponseCompleted(id.local(), byte_count_[id], ""))
           .Times(1);
     } else {
       EXPECT_EQ(0, error_count_[id]);
 
       EXPECT_CALL(*download_manager_,
                   OnDownloadInterrupted(id.local(),
                       byte_count_[id],
@@ skipping 25 matching lines @@
     download_file_manager_->CancelDownload(id);
 
     EXPECT_TRUE(NULL == download_file_manager_->GetDownloadFile(id));
   }
 
  protected:
   scoped_refptr<MockDownloadManager> download_manager_;
   scoped_ptr<MockDownloadRequestHandle> request_handle_;
   MockDownloadFileFactory* download_file_factory_;
   scoped_refptr<DownloadFileManager> download_file_manager_;
-  scoped_refptr<content::DownloadBuffer> download_buffer_;
 
   // Per-download statistics.
   std::map<DownloadId, int64> byte_count_;
   std::map<DownloadId, int> error_count_;
 
  private:
   MessageLoop loop_;
 
   // UI thread.
   BrowserThreadImpl ui_thread_;
@@ skipping 24 matching lines @@
   CleanUp(dummy_id);
 }
 
 TEST_F(DownloadFileManagerTest, CancelBeforeFinished) {
   // Same as StartDownload, at first.
   DownloadCreateInfo* info = new DownloadCreateInfo;
   DownloadId dummy_id(download_manager_.get(), kDummyDownloadId);
 
   StartDownload(info, dummy_id);
 
-  UpdateDownload(dummy_id, kTestData1, strlen(kTestData1), net::OK);
-  UpdateDownload(dummy_id, kTestData2, strlen(kTestData2), net::OK);
-  UpdateDownload(dummy_id, kTestData3, strlen(kTestData3), net::OK);
-
   CleanUp(dummy_id);
 }
 
 TEST_F(DownloadFileManagerTest, DownloadWithError) {
   // Same as StartDownload, at first.
   DownloadCreateInfo* info = new DownloadCreateInfo;
   DownloadId dummy_id(download_manager_.get(), kDummyDownloadId);
 
   StartDownload(info, dummy_id);
 
-  UpdateDownload(dummy_id, kTestData1, strlen(kTestData1), net::OK);
-  UpdateDownload(dummy_id, kTestData2, strlen(kTestData2),
-                 net::ERR_FILE_NO_SPACE);
 }
 
 TEST_F(DownloadFileManagerTest, CompleteDownload) {
   // Same as StartDownload, at first.
   DownloadCreateInfo* info = new DownloadCreateInfo;
   DownloadId dummy_id(download_manager_.get(), kDummyDownloadId);
 
   StartDownload(info, dummy_id);
 
-  UpdateDownload(dummy_id, kTestData1, strlen(kTestData1), net::OK);
-  UpdateDownload(dummy_id, kTestData2, strlen(kTestData2), net::OK);
-  UpdateDownload(dummy_id, kTestData3, strlen(kTestData3), net::OK);
-
   OnResponseCompleted(dummy_id, content::DOWNLOAD_INTERRUPT_REASON_NONE, "");
 
   CleanUp(dummy_id);
 }
 
 TEST_F(DownloadFileManagerTest, CompleteDownloadWithError) {
   // Same as StartDownload, at first.
   DownloadCreateInfo* info = new DownloadCreateInfo;
   DownloadId dummy_id(download_manager_.get(), kDummyDownloadId);
 
   StartDownload(info, dummy_id);
 
-  UpdateDownload(dummy_id, kTestData1, strlen(kTestData1), net::OK);
-  UpdateDownload(dummy_id, kTestData2, strlen(kTestData2), net::OK);
-  UpdateDownload(dummy_id, kTestData3, strlen(kTestData3), net::OK);
-
   OnResponseCompleted(dummy_id,
                       content::DOWNLOAD_INTERRUPT_REASON_FILE_VIRUS_INFECTED,
                       "");
 
   CleanUp(dummy_id);
 }
 
 TEST_F(DownloadFileManagerTest, RenameInProgress) {
   // Same as StartDownload, at first.
   DownloadCreateInfo* info = new DownloadCreateInfo;
   DownloadId dummy_id(download_manager_.get(), kDummyDownloadId);
   ScopedTempDir download_dir;
   ASSERT_TRUE(download_dir.CreateUniqueTempDir());
 
   StartDownload(info, dummy_id);
 
-  UpdateDownload(dummy_id, kTestData1, strlen(kTestData1), net::OK);
-  UpdateDownload(dummy_id, kTestData2, strlen(kTestData2), net::OK);
   FilePath foo(download_dir.path().Append(FILE_PATH_LITERAL("foo.txt")));
   RenameFile(dummy_id, foo, foo, net::OK, IN_PROGRESS, OVERWRITE);
-  UpdateDownload(dummy_id, kTestData3, strlen(kTestData3), net::OK);
 
   OnResponseCompleted(dummy_id, content::DOWNLOAD_INTERRUPT_REASON_NONE, "");
 
   CleanUp(dummy_id);
 }
 
 TEST_F(DownloadFileManagerTest, RenameInProgressWithError) {
   // Same as StartDownload, at first.
   DownloadCreateInfo* info = new DownloadCreateInfo;
   DownloadId dummy_id(download_manager_.get(), kDummyDownloadId);
   ScopedTempDir download_dir;
   ASSERT_TRUE(download_dir.CreateUniqueTempDir());
 
   StartDownload(info, dummy_id);
 
-  UpdateDownload(dummy_id, kTestData1, strlen(kTestData1), net::OK);
-  UpdateDownload(dummy_id, kTestData2, strlen(kTestData2), net::OK);
   FilePath foo(download_dir.path().Append(FILE_PATH_LITERAL("foo.txt")));
   RenameFile(dummy_id, foo, foo, net::ERR_FILE_PATH_TOO_LONG,
              IN_PROGRESS, OVERWRITE);
 
   CleanUp(dummy_id);
 }
 
 TEST_F(DownloadFileManagerTest, RenameCompleting) {
   // Same as StartDownload, at first.
   DownloadCreateInfo* info = new DownloadCreateInfo;
   DownloadId dummy_id(download_manager_.get(), kDummyDownloadId);
   ScopedTempDir download_dir;
   ASSERT_TRUE(download_dir.CreateUniqueTempDir());
 
   StartDownload(info, dummy_id);
 
-  UpdateDownload(dummy_id, kTestData1, strlen(kTestData1), net::OK);
-  UpdateDownload(dummy_id, kTestData2, strlen(kTestData2), net::OK);
-  UpdateDownload(dummy_id, kTestData3, strlen(kTestData3), net::OK);
-
   OnResponseCompleted(dummy_id, content::DOWNLOAD_INTERRUPT_REASON_NONE, "");
 
   FilePath foo(download_dir.path().Append(FILE_PATH_LITERAL("foo.txt")));
   RenameFile(dummy_id, foo, foo, net::OK, COMPLETE, OVERWRITE);
 
   CleanUp(dummy_id);
 }
 
 TEST_F(DownloadFileManagerTest, RenameCompletingWithUniquification) {
   // Same as StartDownload, at first.
   DownloadCreateInfo* info = new DownloadCreateInfo;
   DownloadId dummy_id(download_manager_.get(), kDummyDownloadId);
   ScopedTempDir download_dir;
   ASSERT_TRUE(download_dir.CreateUniqueTempDir());
 
   StartDownload(info, dummy_id);
 
-  UpdateDownload(dummy_id, kTestData1, strlen(kTestData1), net::OK);
-  UpdateDownload(dummy_id, kTestData2, strlen(kTestData2), net::OK);
-  UpdateDownload(dummy_id, kTestData3, strlen(kTestData3), net::OK);
-
   OnResponseCompleted(dummy_id, content::DOWNLOAD_INTERRUPT_REASON_NONE, "");
 
   FilePath foo(download_dir.path().Append(FILE_PATH_LITERAL("foo.txt")));
   FilePath unique_foo(foo.InsertBeforeExtension(FILE_PATH_LITERAL(" (1)")));
   // Create a file at |foo|. Since we are specifying DONT_OVERWRITE,
   // RenameCompletingDownloadFile() should pick "foo (1).txt" instead of
   // overwriting this file.
   ASSERT_EQ(0, file_util::WriteFile(foo, "", 0));
   RenameFile(dummy_id, foo, unique_foo, net::OK, COMPLETE, DONT_OVERWRITE);
 
   CleanUp(dummy_id);
 }
 
 TEST_F(DownloadFileManagerTest, RenameCompletingWithError) {
   // Same as StartDownload, at first.
   DownloadCreateInfo* info = new DownloadCreateInfo;
   DownloadId dummy_id(download_manager_.get(), kDummyDownloadId);
   ScopedTempDir download_dir;
   ASSERT_TRUE(download_dir.CreateUniqueTempDir());
 
   StartDownload(info, dummy_id);
 
-  UpdateDownload(dummy_id, kTestData1, strlen(kTestData1), net::OK);
-  UpdateDownload(dummy_id, kTestData2, strlen(kTestData2), net::OK);
-  UpdateDownload(dummy_id, kTestData3, strlen(kTestData3), net::OK);
-
   OnResponseCompleted(dummy_id, content::DOWNLOAD_INTERRUPT_REASON_NONE, "");
 
   FilePath foo(download_dir.path().Append(FILE_PATH_LITERAL("foo.txt")));
   RenameFile(dummy_id, foo, foo, net::ERR_FILE_PATH_TOO_LONG,
              COMPLETE, OVERWRITE);
 
   CleanUp(dummy_id);
 }
 
 TEST_F(DownloadFileManagerTest, RenameTwice) {
   // Same as StartDownload, at first.
   DownloadCreateInfo* info = new DownloadCreateInfo;
   DownloadId dummy_id(download_manager_.get(), kDummyDownloadId);
   ScopedTempDir download_dir;
   ASSERT_TRUE(download_dir.CreateUniqueTempDir());
 
   StartDownload(info, dummy_id);
 
-  UpdateDownload(dummy_id, kTestData1, strlen(kTestData1), net::OK);
-  UpdateDownload(dummy_id, kTestData2, strlen(kTestData2), net::OK);
   FilePath crfoo(download_dir.path().Append(
       FILE_PATH_LITERAL("foo.txt.crdownload")));
   RenameFile(dummy_id, crfoo, crfoo, net::OK, IN_PROGRESS, OVERWRITE);
-  UpdateDownload(dummy_id, kTestData3, strlen(kTestData3), net::OK);
 
   OnResponseCompleted(dummy_id, content::DOWNLOAD_INTERRUPT_REASON_NONE, "");
 
   FilePath foo(download_dir.path().Append(FILE_PATH_LITERAL("foo.txt")));
   RenameFile(dummy_id, foo, foo, net::OK, COMPLETE, OVERWRITE);
 
   CleanUp(dummy_id);
 }
 
 TEST_F(DownloadFileManagerTest, TwoDownloads) {
   // Same as StartDownload, at first.
   DownloadCreateInfo* info = new DownloadCreateInfo;
   DownloadCreateInfo* info2 = new DownloadCreateInfo;
   DownloadId dummy_id(download_manager_.get(), kDummyDownloadId);
   DownloadId dummy_id2(download_manager_.get(), kDummyDownloadId2);
   ScopedTempDir download_dir;
   ASSERT_TRUE(download_dir.CreateUniqueTempDir());
 
   StartDownload(info, dummy_id);
 
-  UpdateDownload(dummy_id, kTestData1, strlen(kTestData1), net::OK);
 
   StartDownload(info2, dummy_id2);
 
-  UpdateDownload(dummy_id, kTestData2, strlen(kTestData2), net::OK);
-
-  UpdateDownload(dummy_id2, kTestData4, strlen(kTestData4), net::OK);
   FilePath crbar(download_dir.path().Append(
       FILE_PATH_LITERAL("bar.txt.crdownload")));
   RenameFile(dummy_id2, crbar, crbar, net::OK, IN_PROGRESS, OVERWRITE);
 
   FilePath crfoo(download_dir.path().Append(
       FILE_PATH_LITERAL("foo.txt.crdownload")));
   RenameFile(dummy_id, crfoo, crfoo, net::OK, IN_PROGRESS, OVERWRITE);
 
-  UpdateDownload(dummy_id, kTestData3, strlen(kTestData3), net::OK);
-
-  UpdateDownload(dummy_id2, kTestData5, strlen(kTestData5), net::OK);
-  UpdateDownload(dummy_id2, kTestData6, strlen(kTestData6), net::OK);
-
   OnResponseCompleted(dummy_id2, content::DOWNLOAD_INTERRUPT_REASON_NONE, "");
 
   OnResponseCompleted(dummy_id, content::DOWNLOAD_INTERRUPT_REASON_NONE, "");
 
   FilePath bar(download_dir.path().Append(FILE_PATH_LITERAL("bar.txt")));
   RenameFile(dummy_id2, bar, bar, net::OK, COMPLETE, OVERWRITE);
 
   CleanUp(dummy_id2);
 
   FilePath foo(download_dir.path().Append(FILE_PATH_LITERAL("foo.txt")));
   RenameFile(dummy_id, foo, foo, net::OK, COMPLETE, OVERWRITE);
 
   CleanUp(dummy_id);
 }
 
 
 // TODO(ahendrickson) -- A test for updating progress.
 // Expected call sequence:
 //  UpdateInProgressDownloads
 //    DownloadFile::GetDownloadFile
 //  Process one message in the message loop
 //    DownloadManager::UpdateDownload
 
 // TODO(ahendrickson) -- A test for download manager shutdown.
 // Expected call sequence:
 //  OnDownloadManagerShutdown
 //    DownloadFile::GetDownloadManager
 //    DownloadFile::CancelDownloadRequest
 //    DownloadFile::~DownloadFile