Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: net/test/base_test_server.h

Issue 10073033: Run safebrowsing_service_test through the net testserver code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix warning Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/test/base_test_server.h
diff --git a/net/test/base_test_server.h b/net/test/base_test_server.h
index cd996cbc9056b1a8934b16720b30ed0f85cac2d6..672b44de3145a034834e8b5374a4732e5156464a 100644
--- a/net/test/base_test_server.h
+++ b/net/test/base_test_server.h
@@ -206,7 +206,13 @@ class BaseTestServer {
// Generates a DictionaryValue with the arguments for launching the external
// Python test server.
- bool GenerateArguments(base::DictionaryValue* arguments) const;
+ bool GenerateArguments(base::DictionaryValue* arguments) const
+ WARN_UNUSED_RESULT;
+
+ // Subclasses can override this to add arguments that are specific to their
+ // own test servers.
+ virtual bool GenerateAdditionalArguments(
+ base::DictionaryValue* arguments) const WARN_UNUSED_RESULT;
Ryan Sleevi 2012/08/31 21:48:39 Is there a reason this is public instead of protec
mattm 2012/09/01 01:44:54 is protected, though I had it in the wrong section
private:
void Init(const std::string& host);

Powered by Google App Engine
This is Rietveld 408576698