Issue 10073032: Issue 2081: Expose function's (closure's) inner context in debugger.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10073032: Issue 2081: Expose function's (closure's) inner context in debugger. (Closed)

Created:
8 years, 8 months ago by Peter Rybin

Modified:
8 years, 8 months ago

Reviewers:
Søren Thygesen Gjesse, Søren Gjesse, ulan, Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Issue 2081: Expose function's (closure's) inner context in debugger.

Patch Set 1 #

Patch Set 2 : clean #

Patch Set 3 : spelling #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+244 lines, -44 lines)			Patch
M	src/debug-debugger.js	View	1	3 chunks	+39 lines, -18 lines	0 comments	Download
M	src/mirror-debugger.js	View	1	4 chunks	+47 lines, -13 lines	0 comments	Download
M	src/runtime.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View	1	4 chunks	+69 lines, -13 lines	0 comments	Download
A	test/mjsunit/debug-function-scopes.js	View	1 2	1 chunk	+87 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Peter Rybin

Ping. Hi Yang Do you think we could do this change? Thank you, Peter

8 years, 8 months ago (2012-04-18 09:37:20 UTC) #3

Yang

On 2012/04/18 12:00:53, Yang wrote: > Adding ulan as reviewer. The CL should be committed ...

8 years, 8 months ago (2012-04-19 14:13:54 UTC) #5

Peter Rybin

8 years, 8 months ago (2012-04-20 16:23:21 UTC) #6

On 2012/04/19 14:13:54, Yang wrote:
> On 2012/04/18 12:00:53, Yang wrote:
> > Adding ulan as reviewer.
> 
> The CL should be committed to bleeding_edge instead of trunk (Base URL).

Thank you for noting this. Will open a new CL here with identical patch.

Expand Messages | Collapse Messages