Avoiding unnecessary conversion to UTF16 in runtime.

remoting/host/sas_injector_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/sas_injector.h"
 
 #include <windows.h>
 #include <string>
 
 #include "base/logging.h"
 #include "base/file_path.h"
 #include "base/native_library.h"
 #include "base/path_service.h"
-#include "base/utf_string_conversions.h"
+#include "base/stringize_macros.h"
 #include "base/win/registry.h"
 #include "base/win/windows_version.h"
 
 namespace remoting {
 
 namespace {
 
 // Names of the API and library implementing software SAS generation.
 const FilePath::CharType kSasDllFileName[] =
     FILE_PATH_LITERAL("sas.dll");
 const char kSendSasName[] = "SendSAS";
 
 // The prototype of SendSAS().
 typedef VOID (WINAPI *SendSasFunc)(BOOL);
 
 // The registry key and value holding the policy controlling software SAS
 // generation.
-const char kSystemPolicyKeyName[] =
-    "Software\\Microsoft\\Windows\\CurrentVersion\\Policies\\System";
-const char kSoftwareSasValueName[] = "SoftwareSASGeneration";
+const char16 kSystemPolicyKeyName[] =
+    TO_L_STRING("Software\\Microsoft\\Windows\\CurrentVersion\\Policies\\")
+    TO_L_STRING("System");
+const char16 kSoftwareSasValueName[] = TO_L_STRING("SoftwareSASGeneration");
 
 const DWORD kEnableSoftwareSasByServices = 1;
 
 // Toggles the default software SAS generation policy to enable SAS generation
 // by services. Non-default policy is not changed.
 class ScopedSoftwareSasPolicy {
  public:
   ScopedSoftwareSasPolicy();
   ~ScopedSoftwareSasPolicy();
 
   bool Apply();
 
  private:
   // The handle of the registry key were SoftwareSASGeneration policy is stored.
   base::win::RegKey system_policy_;
 
-  // Name of the registry value holding the policy.
-  string16 value_name_;
-
   // True if the policy needs to be restored.
   bool restore_policy_;
 
   DISALLOW_COPY_AND_ASSIGN(ScopedSoftwareSasPolicy);
 };
 
 ScopedSoftwareSasPolicy::ScopedSoftwareSasPolicy()
     : restore_policy_(false) {
 }
 
 ScopedSoftwareSasPolicy::~ScopedSoftwareSasPolicy() {
   // Restore the default policy by deleting the value that we have set.
   if (restore_policy_) {
-    LONG result = system_policy_.DeleteValue(value_name_.c_str());
+    LONG result = system_policy_.DeleteValue(kSoftwareSasValueName);
     if (result != ERROR_SUCCESS) {
       SetLastError(result);
       LOG_GETLASTERROR(ERROR)
           << "Failed to restore the software SAS generation policy";
     }
   }
 }
 
 bool ScopedSoftwareSasPolicy::Apply() {
   // Query the currently set SoftwareSASGeneration policy.
   LONG result = system_policy_.Open(HKEY_LOCAL_MACHINE,
-                                    ASCIIToUTF16(kSystemPolicyKeyName).c_str(),
+                                    kSystemPolicyKeyName,
                                     KEY_QUERY_VALUE | KEY_SET_VALUE |
                                         KEY_WOW64_64KEY);
   if (result != ERROR_SUCCESS) {
     SetLastError(result);
     LOG_GETLASTERROR(ERROR) << "Failed to open 'HKLM\\"
                             << kSystemPolicyKeyName << "'";
     return false;
   }
 
-  value_name_ = ASCIIToUTF16(kSoftwareSasValueName);
-  bool custom_policy = system_policy_.HasValue(value_name_.c_str());
+  bool custom_policy = system_policy_.HasValue(kSoftwareSasValueName);
 
   // Override the default policy (i.e. there is no value in the registry) only.
   if (!custom_policy) {
-    result = system_policy_.WriteValue(value_name_.c_str(),
+    result = system_policy_.WriteValue(kSoftwareSasValueName,
                                        kEnableSoftwareSasByServices);
     if (result != ERROR_SUCCESS) {
       SetLastError(result);
       LOG_GETLASTERROR(ERROR)
           << "Failed to enable software SAS generation by services";
       return false;
     } else {
       restore_policy_ = true;
     }
   }
@@ skipping 72 matching lines @@
 
 scoped_ptr<SasInjector> SasInjector::Create() {
   if (base::win::OSInfo::GetInstance()->version() >= base::win::VERSION_VISTA) {
     return scoped_ptr<SasInjector>(new SasInjectorWin());
   }
 
   return scoped_ptr<SasInjector>();
 }
 
 } // namespace remoting