Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Issue 10073020: mac: Make build_app_dmg more silent. (Closed)

Created:
8 years, 8 months ago by Nico
Modified:
8 years, 8 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

mac: Make build_app_dmg more silent. 1.) Remove `set -x` 2.) Explicitly add '.dmg' extension to output, so pkg-dmg no longer warns about adding this implicitly 3.) Pass '--verbosity 0' to pkg-dmg to tell it to print only errors If build_app_dmg needs to be debugged, it's easy to undo 1 and 3. There's no need to have all this output on every single build. BUG=none TEST=`ninja all` has 38 lines less output. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132424

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M chrome/tools/build/mac/build_app_dmg View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
8 years, 8 months ago (2012-04-13 21:08:46 UTC) #1
Mark Mentovai
LGTM
8 years, 8 months ago (2012-04-16 15:30:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10073020/1
8 years, 8 months ago (2012-04-16 16:12:40 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-16 17:48:41 UTC) #4
Change committed as 132424

Powered by Google App Engine
This is Rietveld 408576698