Fix the optional permissions API.

Fix the optional permissions API.

Make sure the Extension copies in the renderers have the active permissions and not just those defined in the manifest.

BUG=123250
TEST=ExtensionApiTest.ContentScriptPermissionsApi


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132289

[jstritar, 2012-04-13 16:28:15]

Aaron, can you take a look? This regressed a little while ago
(http://codereview.chromium.org/8976003/) due to poor test coverage of that
area.

[Aaron Boodman, 2012-04-13 18:01:01]

LGTM, thanks for the quick turnaround.

I wonder if there is any other computed state in Extension that is going to have
the same problem.

http://codereview.chromium.org/10073011/diff/1/chrome/common/extensions/exten...
File chrome/common/extensions/extension_messages.cc (right):

http://codereview.chromium.org/10073011/diff/1/chrome/common/extensions/exten...
chrome/common/extensions/extension_messages.cc:22:
apis(extension->GetActivePermissions()->apis()),
Bummer.

http://codereview.chromium.org/10073011/diff/1/chrome/common/extensions/exten...
chrome/common/extensions/extension_messages.cc:37: DLOG(ERROR) << "Error
deserializing extension: " << error;
Early return NULL and eliminate else branch.

[jstritar, 2012-04-13 18:31:37]

I can't think of anything else... the other state would be computed within
Extension::Create.

http://codereview.chromium.org/10073011/diff/1/chrome/common/extensions/exten...
File chrome/common/extensions/extension_messages.cc (right):

http://codereview.chromium.org/10073011/diff/1/chrome/common/extensions/exten...
chrome/common/extensions/extension_messages.cc:37: DLOG(ERROR) << "Error
deserializing extension: " << error;
On 2012/04/13 18:01:01, Aaron Boodman wrote:
> Early return NULL and eliminate else branch.

Done.

[commit-bot: I haz the power, 2012-04-13 21:03:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jstritar@chromium.org/10073011/4001

[commit-bot: I haz the power, 2012-04-13 23:06:54]

Change committed as 132289