Issue 10073007: Add network settings to Wifi tab.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10073007: Add network settings to Wifi tab. (Closed)

Created:
8 years, 8 months ago by kevers

Modified:
8 years, 8 months ago

Reviewers:
csilv

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add network settings to Wifi tab. BUG=118255 TEST=Open the internet details dialog for a WiFi connection. Verify that the ip configuration is shown on the connection tab. The contents of the old WiFi and network tabs have been merged for WiFi connections. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132442

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+74 lines, -21 lines)			Patch
M	chrome/app/generated_resources.grd	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	chrome/browser/resources/options2/chromeos/internet_detail.html	View	3 chunks	+43 lines, -15 lines	0 comments	Download
M	chrome/browser/resources/options2/chromeos/internet_detail.js	View	3 chunks	+23 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/options2/chromeos/internet_options_handler2.cc	View	3 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kevers

Hi Chris, Can you please have a look at this CL. It cleans up the ...

8 years, 8 months ago (2012-04-13 14:22:43 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/10073007/1

8 years, 8 months ago (2012-04-16 17:42:17 UTC) #4

Change committed as 132442

Expand Messages | Collapse Messages