Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1724)

Unified Diff: content/renderer/media/audio_message_filter.h

Issue 10071038: RefCounted types should not have public destructors, content/browser part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Copyright bump Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/audio_input_message_filter.h ('k') | content/renderer/media/audio_message_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/audio_message_filter.h
diff --git a/content/renderer/media/audio_message_filter.h b/content/renderer/media/audio_message_filter.h
index 8df9d3f671d703d5753b5d74c51170892f426122..40faeabec271c8d6fbd2c8c0ec3d5c4e221d9340 100644
--- a/content/renderer/media/audio_message_filter.h
+++ b/content/renderer/media/audio_message_filter.h
@@ -38,7 +38,6 @@ class CONTENT_EXPORT AudioMessageFilter
};
AudioMessageFilter();
- virtual ~AudioMessageFilter();
// Add a delegate to the map and return id of the entry.
int32 AddDelegate(Delegate* delegate);
@@ -49,16 +48,19 @@ class CONTENT_EXPORT AudioMessageFilter
// Sends an IPC message using |channel_|.
bool Send(IPC::Message* message);
- private:
- FRIEND_TEST_ALL_PREFIXES(AudioMessageFilterTest, Basic);
- FRIEND_TEST_ALL_PREFIXES(AudioMessageFilterTest, Delegates);
-
// IPC::ChannelProxy::MessageFilter override. Called on IO thread.
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
virtual void OnFilterAdded(IPC::Channel* channel) OVERRIDE;
virtual void OnFilterRemoved() OVERRIDE;
virtual void OnChannelClosing() OVERRIDE;
+ protected:
+ virtual ~AudioMessageFilter();
+
+ private:
+ FRIEND_TEST_ALL_PREFIXES(AudioMessageFilterTest, Basic);
+ FRIEND_TEST_ALL_PREFIXES(AudioMessageFilterTest, Delegates);
+
// Received when browser process has created an audio output stream.
void OnStreamCreated(int stream_id, base::SharedMemoryHandle handle,
#if defined(OS_WIN)
@@ -73,9 +75,6 @@ class CONTENT_EXPORT AudioMessageFilter
// changed.
void OnStreamStateChanged(int stream_id, AudioStreamState state);
- // Notification of volume property of an audio output stream.
- void OnStreamVolume(int stream_id, double volume);
-
// A map of stream ids to delegates.
IDMap<Delegate> delegates_;
« no previous file with comments | « content/renderer/media/audio_input_message_filter.h ('k') | content/renderer/media/audio_message_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698