Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1872)

Unified Diff: content/common/gpu/client/gpu_channel_host.h

Issue 10071038: RefCounted types should not have public destructors, content/browser part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/gpu/client/gpu_channel_host.h
diff --git a/content/common/gpu/client/gpu_channel_host.h b/content/common/gpu/client/gpu_channel_host.h
index 0a888451df89ca7479c9b7ec752a396d2acea96c..483bcdd8d775790ce0ccd71ca9cc38a72e6045b3 100644
--- a/content/common/gpu/client/gpu_channel_host.h
+++ b/content/common/gpu/client/gpu_channel_host.h
@@ -85,7 +85,6 @@ class GpuChannelHost : public IPC::Message::Sender,
GpuChannelHost(GpuChannelHostFactory* factory,
int gpu_process_id,
int client_id);
- virtual ~GpuChannelHost();
// Connect to GPU process channel.
void Connect(const IPC::ChannelHandle& channel_handle,
@@ -156,12 +155,14 @@ class GpuChannelHost : public IPC::Message::Sender,
int client_id() const { return client_id_; }
private:
+ friend class base::RefCountedThreadSafe<GpuChannelHost>;
+ virtual ~GpuChannelHost();
+
// A filter used internally to route incoming messages from the IO thread
// to the correct message loop.
class MessageFilter : public IPC::ChannelProxy::MessageFilter {
public:
explicit MessageFilter(GpuChannelHost* parent);
- virtual ~MessageFilter();
void AddRoute(int route_id,
base::WeakPtr<IPC::Channel::Listener> listener,
@@ -173,6 +174,8 @@ class GpuChannelHost : public IPC::Message::Sender,
virtual void OnChannelError() OVERRIDE;
private:
+ virtual ~MessageFilter();
+
GpuChannelHost* parent_;
typedef base::hash_map<int, GpuListenerInfo> ListenerMap;

Powered by Google App Engine
This is Rietveld 408576698