content/renderer/media/media_stream_impl.h - Issue 10071038: RefCounted types should not have public destructors, content/browser part 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_stream_impl.h

Issue 10071038: RefCounted types should not have public destructors, content/browser part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/media/audio_input_message_filter.h ('K') | « content/renderer/media/capture_video_decoder_unittest.cc ('k') | content/renderer/media/mock_media_stream_impl.h » ('j') | content/renderer/media/video_capture_impl_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/media_stream_impl.h

diff --git a/content/renderer/media/media_stream_impl.h b/content/renderer/media/media_stream_impl.h

index 7a59582d9a4feaa267dc8ca0f2f567a2f355144f..54d674981749708f33650667cc152c382c0c00aa 100644

--- a/content/renderer/media/media_stream_impl.h

+++ b/content/renderer/media/media_stream_impl.h

@@ -70,7 +70,6 @@ class CONTENT_EXPORT MediaStreamImpl

content::P2PSocketDispatcher* p2p_socket_dispatcher,

VideoCaptureImplManager* vc_manager,

MediaStreamDependencyFactory* dependency_factory);

- virtual ~MediaStreamImpl();

virtual WebKit::WebPeerConnectionHandler* CreatePeerConnectionHandler(

WebKit::WebPeerConnectionHandlerClient* client);

@@ -115,6 +114,10 @@ class CONTENT_EXPORT MediaStreamImpl

const media_stream::StreamDeviceInfo& device_info) OVERRIDE;

virtual void OnDeviceOpenFailed(int request_id) OVERRIDE;

+ protected:

+ friend class base::RefCountedThreadSafe<MediaStreamImpl>;

+ virtual ~MediaStreamImpl();

private:

FRIEND_TEST_ALL_PREFIXES(MediaStreamImplTest, Basic);