content/renderer/media/audio_input_device.h - Issue 10071038: RefCounted types should not have public destructors, content/browser part 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/audio_input_device.h

Issue 10071038: RefCounted types should not have public destructors, content/browser part 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/gpu/compositor_thread.cc ('k') | content/renderer/media/audio_input_message_filter.h » ('j') | content/renderer/media/audio_input_message_filter.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/audio_input_device.h

diff --git a/content/renderer/media/audio_input_device.h b/content/renderer/media/audio_input_device.h

index 787dfad72dc4d8d5574b19ea02a04df2c740d756..ff28d7ec4089e316a8fb3dd5a6f41748e43f93f7 100644

--- a/content/renderer/media/audio_input_device.h

+++ b/content/renderer/media/audio_input_device.h

@@ -121,7 +121,6 @@ class CONTENT_EXPORT AudioInputDevice

AudioInputDevice(const media::AudioParameters& params,

CaptureCallback* callback,

CaptureEventHandler* event_handler);

- virtual ~AudioInputDevice();

// Specify the |session_id| to query which device to use. This method is

// asynchronous/non-blocking.

@@ -167,6 +166,9 @@ class CONTENT_EXPORT AudioInputDevice

virtual void OnDeviceReady(const std::string& device_id) OVERRIDE;

private:

+ friend class base::RefCountedThreadSafe<AudioInputDevice>;

+ virtual ~AudioInputDevice();

// Methods called on IO thread ----------------------------------------------

// The following methods are tasks posted on the IO thread that needs to

// be executed on that thread. They interact with AudioInputMessageFilter and