Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: chrome/browser/metrics/field_trial_synchronizer.h

Issue 10071036: RefCounted types should not have public destructors, chrome/browser/ part 6 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/memory_purger.cc ('k') | chrome/browser/metrics/field_trial_synchronizer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/field_trial_synchronizer.h
diff --git a/chrome/browser/metrics/field_trial_synchronizer.h b/chrome/browser/metrics/field_trial_synchronizer.h
index 00d5b80d8b0a8da2435c12568181edd0f34d1f4d..7d96318259bd451f661ea0248fb34616451e4ca5 100644
--- a/chrome/browser/metrics/field_trial_synchronizer.h
+++ b/chrome/browser/metrics/field_trial_synchronizer.h
@@ -35,8 +35,6 @@ class FieldTrialSynchronizer
// is finalized in the browser process.
FieldTrialSynchronizer();
- virtual ~FieldTrialSynchronizer();
-
// Notify all renderer processes about the |group_name| that is finalized for
// the given field trail (|field_trial_name|). This is called on UI thread.
void NotifyAllRenderers(const std::string& field_trial_name,
@@ -53,11 +51,8 @@ class FieldTrialSynchronizer
const std::string& group_name) OVERRIDE;
private:
- // This singleton instance should be constructed during the single threaded
- // portion of main(). It initializes globals to provide support for all future
- // calls. This object is created on the UI thread, and it is destroyed after
- // all the other threads have gone away.
- static FieldTrialSynchronizer* field_trial_synchronizer_;
+ friend class base::RefCountedThreadSafe<FieldTrialSynchronizer>;
+ virtual ~FieldTrialSynchronizer();
DISALLOW_COPY_AND_ASSIGN(FieldTrialSynchronizer);
};
« no previous file with comments | « chrome/browser/memory_purger.cc ('k') | chrome/browser/metrics/field_trial_synchronizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698