chrome/browser/importer/firefox_importer_unittest_utils_mac.cc - Issue 10071036: RefCounted types should not have public destructors, chrome/browser/ part 6

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/importer/firefox_importer_unittest_utils_mac.cc

Issue 10071036: RefCounted types should not have public destructors, chrome/browser/ part 6 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Implementation fixes Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/importer/firefox_importer_unittest_utils_mac.cc

diff --git a/chrome/browser/importer/firefox_importer_unittest_utils_mac.cc b/chrome/browser/importer/firefox_importer_unittest_utils_mac.cc

index afe78e5190b5e4555bfbcd8a85410f55140dcb21..d609cc96e539b487bca9685851ae54836381291e 100644

--- a/chrome/browser/importer/firefox_importer_unittest_utils_mac.cc

+++ b/chrome/browser/importer/firefox_importer_unittest_utils_mac.cc

@@ -166,6 +166,10 @@ class CancellableQuitMsgLoop : public base::RefCounted<CancellableQuitMsgLoop> {

MessageLoop::current()->Quit();

}

bool cancelled_;

+ private:

+ friend class base::RefCounted<CancellableQuitMsgLoop>;

+ ~CancellableQuitMsgLoop() {}

};

// Spin until either a client response arrives or a timeout occurs.

« no previous file with comments | « chrome/browser/importer/external_process_importer_host.cc ('k') | chrome/browser/intranet_redirect_detector.h » ('j') | no next file with comments »