Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2951)

Unified Diff: chrome/browser/background/background_contents_service.cc

Issue 10071036: RefCounted types should not have public destructors, chrome/browser/ part 6 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/background/background_contents_service.cc
diff --git a/chrome/browser/background/background_contents_service.cc b/chrome/browser/background/background_contents_service.cc
index 150f8a94b01f44d0e8f8b7d2ff97a6d56ef280aa..d6dc9a71bdaf04fc88d350bb7f3d137882095afb 100644
--- a/chrome/browser/background/background_contents_service.cc
+++ b/chrome/browser/background/background_contents_service.cc
@@ -61,9 +61,6 @@ class CrashNotificationDelegate : public NotificationDelegate {
extension_id_(extension->id()) {
}
- ~CrashNotificationDelegate() {
- }
-
void Display() {}
void Error() {}
@@ -93,6 +90,8 @@ class CrashNotificationDelegate : public NotificationDelegate {
}
private:
+ virtual ~CrashNotificationDelegate() {}
+
Profile* profile_;
bool is_hosted_app_;
std::string extension_id_;
« no previous file with comments | « chrome/browser/autofill/autofill_external_delegate_unittest.cc ('k') | chrome/browser/chrome_quota_permission_context.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698