Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: chrome/browser/autocomplete/builtin_provider.cc

Issue 10071036: RefCounted types should not have public destructors, chrome/browser/ part 6 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/autocomplete/builtin_provider.h ('k') | chrome/browser/autocomplete/history_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autocomplete/builtin_provider.cc
diff --git a/chrome/browser/autocomplete/builtin_provider.cc b/chrome/browser/autocomplete/builtin_provider.cc
index c72d1d33ba59f97dffb9f281bfc9ab6e22154571..a80ee2d8d289bbbe8d65e593c32b4a6310c6cffe 100644
--- a/chrome/browser/autocomplete/builtin_provider.cc
+++ b/chrome/browser/autocomplete/builtin_provider.cc
@@ -46,8 +46,6 @@ BuiltinProvider::BuiltinProvider(ACProviderListener* listener,
builtins_.push_back(settings + ASCIIToUTF16(kChromeSettingsSubPages[i]));
}
-BuiltinProvider::~BuiltinProvider() {}
-
void BuiltinProvider::Start(const AutocompleteInput& input,
bool minimal_changes) {
matches_.clear();
@@ -108,6 +106,8 @@ void BuiltinProvider::Start(const AutocompleteInput& input,
matches_[i].relevance = kRelevance + matches_.size() - (i + 1);
}
+BuiltinProvider::~BuiltinProvider() {}
+
void BuiltinProvider::AddMatch(const string16& match_string,
const ACMatchClassifications& styles) {
AutocompleteMatch match(this, kRelevance, false,
« no previous file with comments | « chrome/browser/autocomplete/builtin_provider.h ('k') | chrome/browser/autocomplete/history_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698