RefCounted types should not have public destructors, chrome/browser/ part 6

chrome/browser/download/download_extension_api.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_DOWNLOAD_DOWNLOAD_EXTENSION_API_H_
 #define CHROME_BROWSER_DOWNLOAD_DOWNLOAD_EXTENSION_API_H_
 #pragma once
 
 #include <map>
 #include <set>
@@ skipping 65 matching lines @@
 
   // Which subclass is this.
   virtual DownloadsFunctionName function() const = 0;
 
   // Wrap ParseArgs(), RunInternal().
   static bool RunImplImpl(DownloadsFunctionInterface* pimpl);
 };
 
 class SyncDownloadsFunction : public SyncExtensionFunction,
                               public DownloadsFunctionInterface {
- public:
-  virtual bool RunImpl() OVERRIDE;
-
  protected:
   explicit SyncDownloadsFunction(DownloadsFunctionName function);
   virtual ~SyncDownloadsFunction();
+
+  // ExtensionFunction:
+  virtual bool RunImpl() OVERRIDE;
+
+  // DownloadsFunctionInterface:
   virtual DownloadsFunctionName function() const OVERRIDE;
 
  private:
   DownloadsFunctionName function_;
 
   DISALLOW_COPY_AND_ASSIGN(SyncDownloadsFunction);
 };
 
 class AsyncDownloadsFunction : public AsyncExtensionFunction,
                                public DownloadsFunctionInterface {
- public:
-  virtual bool RunImpl() OVERRIDE;
-
  protected:
   explicit AsyncDownloadsFunction(DownloadsFunctionName function);
   virtual ~AsyncDownloadsFunction();
+
+  // ExtensionFunction:
+  virtual bool RunImpl() OVERRIDE;
+
+  // DownloadsFunctionInterface:
   virtual DownloadsFunctionName function() const OVERRIDE;
 
  private:
   DownloadsFunctionName function_;
 
   DISALLOW_COPY_AND_ASSIGN(AsyncDownloadsFunction);
 };
 
 class DownloadsDownloadFunction : public AsyncDownloadsFunction {
  public:
-  DownloadsDownloadFunction();
-  virtual ~DownloadsDownloadFunction();
   DECLARE_EXTENSION_FUNCTION_NAME("experimental.downloads.download");
 
+  DownloadsDownloadFunction();
+
  protected:
+  virtual ~DownloadsDownloadFunction();
+
+  // DownloadsFunctionInterface:
   virtual bool ParseArgs() OVERRIDE;
   virtual bool RunInternal() OVERRIDE;
 
  private:
   struct IOData {
    public:
     IOData();
     ~IOData();
 
     GURL url;
     string16 filename;
     bool save_as;
     base::ListValue* extra_headers;
     std::string method;
     std::string post_body;
     content::ResourceDispatcherHost* rdh;
     content::ResourceContext* resource_context;
     int render_process_host_id;
     int render_view_host_routing_id;
   };
+
   void BeginDownloadOnIOThread();
   void OnStarted(content::DownloadId dl_id, net::Error error);
 
   scoped_ptr<IOData> iodata_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadsDownloadFunction);
 };
 
 class DownloadsSearchFunction : public SyncDownloadsFunction {
  public:
-  DownloadsSearchFunction();
-  virtual ~DownloadsSearchFunction();
   DECLARE_EXTENSION_FUNCTION_NAME("experimental.downloads.search");
 
+  DownloadsSearchFunction();
+
  protected:
+  virtual ~DownloadsSearchFunction();
+
+  // DownloadsFunctionInterface:
   virtual bool ParseArgs() OVERRIDE;
   virtual bool RunInternal() OVERRIDE;
 
  private:
   bool ParseOrderBy(const base::Value& order_by_value);
 
   scoped_ptr<DownloadQuery> query_;
   int get_id_;
   bool has_get_id_;
 
   DISALLOW_COPY_AND_ASSIGN(DownloadsSearchFunction);
 };
 
 class DownloadsPauseFunction : public SyncDownloadsFunction {
  public:
-  DownloadsPauseFunction();
-  virtual ~DownloadsPauseFunction();
   DECLARE_EXTENSION_FUNCTION_NAME("experimental.downloads.pause");
 
+  DownloadsPauseFunction();
+
  protected:
+  virtual ~DownloadsPauseFunction();
+
+  // DownloadsFunctionInterface:
   virtual bool ParseArgs() OVERRIDE;
   virtual bool RunInternal() OVERRIDE;
 
  private:
   int download_id_;
   DISALLOW_COPY_AND_ASSIGN(DownloadsPauseFunction);
 };
 
 class DownloadsResumeFunction : public SyncDownloadsFunction {
  public:
-  DownloadsResumeFunction();
-  virtual ~DownloadsResumeFunction();
   DECLARE_EXTENSION_FUNCTION_NAME("experimental.downloads.resume");
 
+  DownloadsResumeFunction();
+
  protected:
+  virtual ~DownloadsResumeFunction();
+
+  // DownloadsFunctionInterface:
   virtual bool ParseArgs() OVERRIDE;
   virtual bool RunInternal() OVERRIDE;
 
  private:
   int download_id_;
   DISALLOW_COPY_AND_ASSIGN(DownloadsResumeFunction);
 };
 
 class DownloadsCancelFunction : public SyncDownloadsFunction {
  public:
-  DownloadsCancelFunction();
-  virtual ~DownloadsCancelFunction();
   DECLARE_EXTENSION_FUNCTION_NAME("experimental.downloads.cancel");
 
+  DownloadsCancelFunction();
+
  protected:
+  virtual ~DownloadsCancelFunction();
+
+  // DownloadsFunctionInterface:
   virtual bool ParseArgs() OVERRIDE;
   virtual bool RunInternal() OVERRIDE;
 
  private:
   int download_id_;
   DISALLOW_COPY_AND_ASSIGN(DownloadsCancelFunction);
 };
 
 class DownloadsEraseFunction : public AsyncDownloadsFunction {
  public:
-  DownloadsEraseFunction();
-  virtual ~DownloadsEraseFunction();
   DECLARE_EXTENSION_FUNCTION_NAME("experimental.downloads.erase");
 
+  DownloadsEraseFunction();
+
  protected:
+  virtual ~DownloadsEraseFunction();
+
+  // DownloadsFunctionInterface:
   virtual bool ParseArgs() OVERRIDE;
   virtual bool RunInternal() OVERRIDE;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(DownloadsEraseFunction);
 };
 
 class DownloadsSetDestinationFunction : public AsyncDownloadsFunction {
  public:
-  DownloadsSetDestinationFunction();
-  virtual ~DownloadsSetDestinationFunction();
   DECLARE_EXTENSION_FUNCTION_NAME("experimental.downloads.setDestination");
 
+  DownloadsSetDestinationFunction();
+
  protected:
+  virtual ~DownloadsSetDestinationFunction();
+
+  // DownloadsFunctionInterface:
   virtual bool ParseArgs() OVERRIDE;
   virtual bool RunInternal() OVERRIDE;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(DownloadsSetDestinationFunction);
 };
 
 class DownloadsAcceptDangerFunction : public AsyncDownloadsFunction {
  public:
-  DownloadsAcceptDangerFunction();
-  virtual ~DownloadsAcceptDangerFunction();
   DECLARE_EXTENSION_FUNCTION_NAME("experimental.downloads.acceptDanger");
 
+  DownloadsAcceptDangerFunction();
+
  protected:
+  virtual ~DownloadsAcceptDangerFunction();
+
+  // DownloadsFunctionInterface:
   virtual bool ParseArgs() OVERRIDE;
   virtual bool RunInternal() OVERRIDE;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(DownloadsAcceptDangerFunction);
 };
 
 class DownloadsShowFunction : public AsyncDownloadsFunction {
  public:
-  DownloadsShowFunction();
-  virtual ~DownloadsShowFunction();
   DECLARE_EXTENSION_FUNCTION_NAME("experimental.downloads.show");
 
+  DownloadsShowFunction();
+
  protected:
+  virtual ~DownloadsShowFunction();
+
+  // DownloadsFunctionInterface:
   virtual bool ParseArgs() OVERRIDE;
   virtual bool RunInternal() OVERRIDE;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(DownloadsShowFunction);
 };
 
 class DownloadsDragFunction : public AsyncDownloadsFunction {
  public:
-  DownloadsDragFunction();
-  virtual ~DownloadsDragFunction();
   DECLARE_EXTENSION_FUNCTION_NAME("experimental.downloads.drag");
 
+  DownloadsDragFunction();
+
  protected:
+  virtual ~DownloadsDragFunction();
+
+  // DownloadsFunctionInterface:
   virtual bool ParseArgs() OVERRIDE;
   virtual bool RunInternal() OVERRIDE;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(DownloadsDragFunction);
 };
 
 class DownloadsGetFileIconFunction : public AsyncDownloadsFunction {
  public:
-  DownloadsGetFileIconFunction();
-  virtual ~DownloadsGetFileIconFunction();
-  void SetIconExtractorForTesting(DownloadFileIconExtractor* extractor);
   DECLARE_EXTENSION_FUNCTION_NAME("experimental.downloads.getFileIcon");
 
+  DownloadsGetFileIconFunction();
+  void SetIconExtractorForTesting(DownloadFileIconExtractor* extractor);
+
  protected:
+  virtual ~DownloadsGetFileIconFunction();
+
+  // DownloadsFunctionInterface:
   virtual bool ParseArgs() OVERRIDE;
   virtual bool RunInternal() OVERRIDE;
 
  private:
   void OnIconURLExtracted(const std::string& url);
   FilePath path_;
   int icon_size_;
   scoped_ptr<DownloadFileIconExtractor> icon_extractor_;
   DISALLOW_COPY_AND_ASSIGN(DownloadsGetFileIconFunction);
 };
@@ skipping 30 matching lines @@
   content::DownloadManager* manager_;
   ItemMap downloads_;
   ItemJsonMap item_jsons_;
   STLValueDeleter<ItemJsonMap> delete_item_jsons_;
   OnChangedStatMap on_changed_stats_;
   STLValueDeleter<OnChangedStatMap> delete_on_changed_stats_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionDownloadsEventRouter);
 };
 #endif  // CHROME_BROWSER_DOWNLOAD_DOWNLOAD_EXTENSION_API_H_