Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Side by Side Diff: chrome/browser/download/download_browsertest.cc

Issue 10071036: RefCounted types should not have public destructors, chrome/browser/ part 6 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation fixes Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <sstream> 5 #include <sstream>
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/file_path.h" 9 #include "base/file_path.h"
10 #include "base/file_util.h" 10 #include "base/file_util.h"
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 SetDownloadManager( 86 SetDownloadManager(
87 DownloadServiceFactory::GetForProfile(profile)->GetDownloadManager()); 87 DownloadServiceFactory::GetForProfile(profile)->GetDownloadManager());
88 } 88 }
89 89
90 virtual void ChooseDownloadPath(WebContents* web_contents, 90 virtual void ChooseDownloadPath(WebContents* web_contents,
91 const FilePath& suggested_path, 91 const FilePath& suggested_path,
92 int32 download_id) OVERRIDE { 92 int32 download_id) OVERRIDE {
93 if (download_manager_) 93 if (download_manager_)
94 download_manager_->FileSelected(suggested_path, download_id); 94 download_manager_->FileSelected(suggested_path, download_id);
95 } 95 }
96
97 protected:
98 virtual ~PickSuggestedFileDelegate() {}
96 }; 99 };
97 100
98 // Get History Information. 101 // Get History Information.
99 class DownloadsHistoryDataCollector { 102 class DownloadsHistoryDataCollector {
100 public: 103 public:
101 DownloadsHistoryDataCollector(int64 download_db_handle, 104 DownloadsHistoryDataCollector(int64 download_db_handle,
102 DownloadManager* manager) 105 DownloadManager* manager)
103 : result_valid_(false), 106 : result_valid_(false),
104 download_db_handle_(download_db_handle) { 107 download_db_handle_(download_db_handle) {
105 HistoryService* hs = 108 HistoryService* hs =
(...skipping 2389 matching lines...) Expand 10 before | Expand all | Expand 10 after
2495 downloads.clear(); 2498 downloads.clear();
2496 GetDownloads(browser(), &downloads); 2499 GetDownloads(browser(), &downloads);
2497 EXPECT_EQ(0u, downloads.size()); 2500 EXPECT_EQ(0u, downloads.size());
2498 2501
2499 if (creation_observer->succeeded()) { 2502 if (creation_observer->succeeded()) {
2500 // Wait until the download is done. We don't care how it's finished. 2503 // Wait until the download is done. We don't care how it's finished.
2501 backup_observer.WaitForFinished(); 2504 backup_observer.WaitForFinished();
2502 } 2505 }
2503 DownloadManagerForBrowser(browser())->RemoveAllDownloads(); 2506 DownloadManagerForBrowser(browser())->RemoveAllDownloads();
2504 } 2507 }
OLDNEW
« no previous file with comments | « chrome/browser/debugger/devtools_sanity_unittest.cc ('k') | chrome/browser/download/download_extension_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698