Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Side by Side Diff: chrome/browser/debugger/devtools_sanity_unittest.cc

Issue 10071036: RefCounted types should not have public destructors, chrome/browser/ part 6 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Implementation fixes Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/cancelable_callback.h" 6 #include "base/cancelable_callback.h"
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
269 }; 269 };
270 270
271 class WorkerDevToolsSanityTest : public InProcessBrowserTest { 271 class WorkerDevToolsSanityTest : public InProcessBrowserTest {
272 public: 272 public:
273 WorkerDevToolsSanityTest() : window_(NULL) { 273 WorkerDevToolsSanityTest() : window_(NULL) {
274 set_show_window(true); 274 set_show_window(true);
275 EnableDOMAutomation(); 275 EnableDOMAutomation();
276 } 276 }
277 277
278 protected: 278 protected:
279 struct WorkerData : public base::RefCountedThreadSafe<WorkerData> { 279 class WorkerData : public base::RefCountedThreadSafe<WorkerData> {
280 public:
280 WorkerData() : worker_process_id(0), worker_route_id(0) {} 281 WorkerData() : worker_process_id(0), worker_route_id(0) {}
281 int worker_process_id; 282 int worker_process_id;
282 int worker_route_id; 283 int worker_route_id;
284
285 private:
286 friend class base::RefCountedThreadSafe<WorkerData>;
287 ~WorkerData() {}
283 }; 288 };
284 289
285 class WorkerCreationObserver : public WorkerServiceObserver { 290 class WorkerCreationObserver : public WorkerServiceObserver {
286 public: 291 public:
287 explicit WorkerCreationObserver(WorkerData* worker_data) 292 explicit WorkerCreationObserver(WorkerData* worker_data)
288 : worker_data_(worker_data) { 293 : worker_data_(worker_data) {
289 } 294 }
290 295
291 private: 296 private:
292 virtual ~WorkerCreationObserver() {} 297 virtual ~WorkerCreationObserver() {}
(...skipping 315 matching lines...) Expand 10 before | Expand all | Expand 10 after
608 content::CONSOLE_MESSAGE_LEVEL_LOG, 613 content::CONSOLE_MESSAGE_LEVEL_LOG,
609 "log"); 614 "log");
610 devtools_manager->AddMessageToConsole(agent_host, 615 devtools_manager->AddMessageToConsole(agent_host,
611 content::CONSOLE_MESSAGE_LEVEL_ERROR, 616 content::CONSOLE_MESSAGE_LEVEL_ERROR,
612 "error"); 617 "error");
613 RunTestFunction(window_, "checkLogAndErrorMessages"); 618 RunTestFunction(window_, "checkLogAndErrorMessages");
614 CloseDevToolsWindow(); 619 CloseDevToolsWindow();
615 } 620 }
616 621
617 } // namespace 622 } // namespace
OLDNEW
« no previous file with comments | « chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc ('k') | chrome/browser/download/download_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698